Skip to content

feat(discovery-core): add transfer preflight check - #474

Merged
m-kus merged 1 commit into
mainfrom
pr-split/13-preflight
Feb 19, 2026
Merged

m-kus merged 1 commit into
mainfrom
pr-split/13-preflight

Conversation

@m-kus

@m-kus m-kus commented Feb 11, 2026 •

Copy link
Copy Markdown

Add preflight check for transfer readiness

Adds a new module for checking transfer readiness before attempting a transfer. The preflight check determines:

  1. If the sender has a public key registered on-chain
  2. If a channel exists between sender and recipient
  3. If the token subchannel exists within that channel

This allows the UI to guide users through the necessary setup steps before attempting a transfer, improving the user experience by preventing failed transactions.

The implementation performs at most 4 direct storage lookups with no scanning required, making it efficient for pre-transaction validation.

This change is Reviewable

@m-kus
m-kus marked this pull request as ready for review February 11, 2026 16:41
@m-kus
m-kus requested a review from Yoni-Starkware February 11, 2026 16:42
@m-kus
m-kus force-pushed the pr-split/12-outgoing-sync branch from 57f57d7 to f3313de Compare February 11, 2026 19:10
@m-kus
m-kus force-pushed the pr-split/13-preflight branch from 4730e63 to 6c960a5 Compare February 11, 2026 19:10

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @m-kus).

@m-kus
m-kus force-pushed the pr-split/12-outgoing-sync branch from f3313de to a9e0712 Compare February 13, 2026 01:49
@m-kus
m-kus force-pushed the pr-split/13-preflight branch 2 times, most recently from 9738666 to a4c586e Compare February 13, 2026 02:02
@m-kus
m-kus force-pushed the pr-split/12-outgoing-sync branch from a9e0712 to 8a9360d Compare February 13, 2026 02:02
@m-kus
m-kus force-pushed the pr-split/13-preflight branch from a4c586e to b91c9b1 Compare February 13, 2026 02:07
@m-kus
m-kus force-pushed the pr-split/12-outgoing-sync branch from 8a9360d to fe37bfb Compare February 13, 2026 02:07
@m-kus
m-kus force-pushed the pr-split/13-preflight branch from b91c9b1 to 952f416 Compare February 13, 2026 02:23
@m-kus
m-kus force-pushed the pr-split/12-outgoing-sync branch from fe37bfb to 81240cc Compare February 13, 2026 02:23
@m-kus
m-kus force-pushed the pr-split/13-preflight branch 2 times, most recently from 7882a43 to 950e3c4 Compare February 17, 2026 13:56
@m-kus
m-kus force-pushed the pr-split/12-outgoing-sync branch 2 times, most recently from 784d819 to 7ef3112 Compare February 17, 2026 17:13
@m-kus
m-kus force-pushed the pr-split/13-preflight branch 2 times, most recently from 5953203 to e811997 Compare February 18, 2026 15:12
@m-kus
m-kus force-pushed the pr-split/12-outgoing-sync branch from 7ef3112 to 57e7866 Compare February 18, 2026 15:12
@m-kus
m-kus force-pushed the pr-split/13-preflight branch from e811997 to 7e12568 Compare February 18, 2026 16:03
@m-kus
m-kus changed the base branch from pr-split/12-outgoing-sync to graphite-base/474 February 18, 2026 16:57
@m-kus
m-kus force-pushed the graphite-base/474 branch from 03731f2 to 91af1d8 Compare February 18, 2026 19:13
@m-kus
m-kus force-pushed the pr-split/13-preflight branch from 7e12568 to 4f51bad Compare February 18, 2026 19:13
@m-kus
m-kus changed the base branch from graphite-base/474 to pr-split/12-outgoing-sync February 18, 2026 19:13
@m-kus
m-kus force-pushed the pr-split/12-outgoing-sync branch from 91af1d8 to 8121167 Compare February 19, 2026 15:06
@m-kus
m-kus force-pushed the pr-split/13-preflight branch 2 times, most recently from 17e5d48 to db4fab8 Compare February 19, 2026 15:41
@m-kus
m-kus force-pushed the pr-split/12-outgoing-sync branch from 8121167 to ef68149 Compare February 19, 2026 15:41
Base automatically changed from pr-split/12-outgoing-sync to main February 19, 2026 16:15
@m-kus
m-kus force-pushed the pr-split/13-preflight branch from db4fab8 to d1fc118 Compare February 19, 2026 16:16
@m-kus
m-kus enabled auto-merge (squash) February 19, 2026 16:17
@m-kus
m-kus merged commit e4ff762 into main Feb 19, 2026
6 checks passed
@m-kus
m-kus deleted the pr-split/13-preflight branch February 19, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants