Skip to content

refactor(indexer): move devnet dump generation to a separate script, scaffold e2e tests dir - #454

Merged
m-kus merged 1 commit into
mainfrom
pr-split/00-e2e-scaffold
Feb 11, 2026
Merged

m-kus merged 1 commit into
mainfrom
pr-split/00-e2e-scaffold

Conversation

@m-kus

@m-kus m-kus commented Feb 9, 2026 •

Copy link
Copy Markdown

TL;DR

Improve test fixture generation by adding a dedicated script and updating the file extraction pattern in PR splitter skill.

What changed?

  • Added a dedicated e2e directory with proper TypeScript setup for end-to-end testing
  • Created a generate-dump.ts script to produce test fixtures for Rust crates
  • Updated the comment in devnet-state.json to reference the new generation method
  • Removed redundant dump functionality from the SDK's Devnet class

This change is Reviewable

m-kus commented Feb 9, 2026 •

Copy link
Copy Markdown
Author

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @m-kus).

@m-kus
m-kus force-pushed the 02-09-feat_claude_pr_splitter_skill branch from 9d4b18f to 3093e15 Compare February 11, 2026 12:08
Base automatically changed from 02-09-feat_claude_pr_splitter_skill to main February 11, 2026 12:11
@m-kus
m-kus force-pushed the pr-split/00-e2e-scaffold branch from 3313a16 to caeb183 Compare February 11, 2026 12:12
@m-kus
m-kus changed the base branch from main to graphite-base/454 February 11, 2026 12:35
@m-kus
m-kus force-pushed the pr-split/00-e2e-scaffold branch from caeb183 to 9967104 Compare February 11, 2026 12:35
@m-kus
m-kus changed the base branch from graphite-base/454 to 02-11-fix_sdk_sync_sdk_with_cairo_contract_renames_to_addr_enc_user_addr_hash_ February 11, 2026 12:35
@m-kus
m-kus force-pushed the pr-split/00-e2e-scaffold branch from 9967104 to 9c7fb89 Compare February 11, 2026 13:05
@m-kus
m-kus changed the base branch from 02-11-fix_sdk_sync_sdk_with_cairo_contract_renames_to_addr_enc_user_addr_hash_ to graphite-base/454 February 11, 2026 13:20
@m-kus
m-kus force-pushed the pr-split/00-e2e-scaffold branch from 9c7fb89 to da898a5 Compare February 11, 2026 14:24
@m-kus
m-kus force-pushed the graphite-base/454 branch from 2e97a5e to b864bef Compare February 11, 2026 14:24
@m-kus
m-kus changed the base branch from graphite-base/454 to 02-11-fix_sdk_sync_sdk_with_cairo_contract_renames_to_addr_enc_user_addr_hash_ February 11, 2026 14:24
@m-kus
m-kus force-pushed the pr-split/00-e2e-scaffold branch from da898a5 to c2efaa0 Compare February 11, 2026 14:29
@m-kus
m-kus force-pushed the 02-11-fix_sdk_sync_sdk_with_cairo_contract_renames_to_addr_enc_user_addr_hash_ branch 2 times, most recently from bcd6e0d to 9f6fd8b Compare February 11, 2026 16:08

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @m-kus).

@m-kus
m-kus force-pushed the 02-11-fix_sdk_sync_sdk_with_cairo_contract_renames_to_addr_enc_user_addr_hash_ branch from 9f6fd8b to afa1231 Compare February 11, 2026 18:07
Base automatically changed from 02-11-fix_sdk_sync_sdk_with_cairo_contract_renames_to_addr_enc_user_addr_hash_ to main February 11, 2026 18:09
@m-kus
m-kus force-pushed the pr-split/00-e2e-scaffold branch 2 times, most recently from db2fb74 to 4aaa326 Compare February 11, 2026 18:15
@m-kus
m-kus force-pushed the pr-split/00-e2e-scaffold branch from 4aaa326 to ce6b197 Compare February 11, 2026 18:26
@m-kus
m-kus merged commit 019245e into main Feb 11, 2026
6 of 8 checks passed
@m-kus
m-kus deleted the pr-split/00-e2e-scaffold branch February 11, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants