feat(discovery-core): paginated subchannel discovery with cursor support - #461
Merged
Merged
Conversation
m-kus
marked this pull request as ready for review
February 9, 2026 19:41
This was referenced Feb 9, 2026
Merged
Author
m-kus
force-pushed
the
pr-split/07-paginated-subchannels
branch
from
February 11, 2026 13:05
9a8ab06 to
97e2373
Compare
m-kus
force-pushed
the
pr-split/06-paginated-incoming
branch
from
February 11, 2026 15:07
3a23638 to
f0b6b73
Compare
m-kus
force-pushed
the
pr-split/07-paginated-subchannels
branch
from
February 11, 2026 15:07
97e2373 to
4858b01
Compare
This was referenced Feb 11, 2026
m-kus
force-pushed
the
pr-split/06-paginated-incoming
branch
from
February 11, 2026 16:08
f0b6b73 to
88cd85e
Compare
m-kus
force-pushed
the
pr-split/07-paginated-subchannels
branch
from
February 11, 2026 16:08
4858b01 to
04787da
Compare
This was referenced Feb 11, 2026
m-kus
force-pushed
the
pr-split/06-paginated-incoming
branch
from
February 11, 2026 19:10
88cd85e to
cd78718
Compare
m-kus
force-pushed
the
pr-split/07-paginated-subchannels
branch
from
February 11, 2026 19:10
04787da to
6be1674
Compare
Yoni-Starkware
approved these changes
Feb 12, 2026
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
Collaborator
There was a problem hiding this comment.
@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @m-kus).
m-kus
changed the base branch from
pr-split/06-paginated-incoming
to
graphite-base/461
February 13, 2026 01:38
m-kus
force-pushed
the
graphite-base/461
branch
from
February 13, 2026 01:47
cd78718 to
acf24fc
Compare
m-kus
force-pushed
the
pr-split/07-paginated-subchannels
branch
from
February 13, 2026 01:47
6be1674 to
24ce52a
Compare
m-kus
changed the base branch from
graphite-base/461
to
pr-split/06-paginated-incoming
February 13, 2026 01:47
This was referenced Feb 13, 2026
m-kus
changed the base branch from
pr-split/06-paginated-incoming
to
graphite-base/461
February 16, 2026 12:43
m-kus
force-pushed
the
graphite-base/461
branch
from
February 16, 2026 13:17
acf24fc to
af8954b
Compare
m-kus
force-pushed
the
pr-split/07-paginated-subchannels
branch
from
February 16, 2026 13:17
24ce52a to
69b0a3b
Compare
m-kus
changed the base branch from
graphite-base/461
to
pr-split/06-paginated-incoming
February 16, 2026 13:17
m-kus
changed the base branch from
pr-split/06-paginated-incoming
to
graphite-base/461
February 16, 2026 16:01
m-kus
force-pushed
the
pr-split/07-paginated-subchannels
branch
from
February 16, 2026 16:02
69b0a3b to
4e2451d
Compare
m-kus
force-pushed
the
graphite-base/461
branch
from
February 16, 2026 16:02
af8954b to
0b5f70f
Compare
m-kus
changed the base branch from
graphite-base/461
to
pr-split/06-paginated-incoming
February 16, 2026 16:02
m-kus
force-pushed
the
pr-split/06-paginated-incoming
branch
from
February 16, 2026 17:54
0b5f70f to
44013c2
Compare
m-kus
force-pushed
the
pr-split/07-paginated-subchannels
branch
from
February 16, 2026 17:54
4e2451d to
2e5c7a4
Compare
m-kus
changed the base branch from
pr-split/06-paginated-incoming
to
graphite-base/461
February 17, 2026 12:18
m-kus
force-pushed
the
pr-split/07-paginated-subchannels
branch
from
February 17, 2026 12:22
2e5c7a4 to
0c3a580
Compare
m-kus
force-pushed
the
graphite-base/461
branch
from
February 17, 2026 12:22
44013c2 to
50712b5
Compare
m-kus
force-pushed
the
pr-split/07-paginated-subchannels
branch
from
February 17, 2026 12:23
0c3a580 to
9a4cb36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a cursor-based pagination mechanism for subchannel discovery with improved logging and caching.
What changed?
discover_subchannels_paginatedfunction that builds on the existingdiscover_subchannelsfunctionSubchannelDiscoveryResult.last_indexto clarify its usageThis change is