Repository navigation
Conversation
Author
m-kus
force-pushed
the
02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation
branch
from
February 12, 2026 12:55
a82df61 to
000f4e3
Compare
m-kus
marked this pull request as ready for review
February 12, 2026 12:55
m-kus
force-pushed
the
02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation
branch
from
February 12, 2026 17:44
000f4e3 to
26e5c4d
Compare
m-kus
force-pushed
the
02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation
branch
8 times, most recently
from
February 12, 2026 18:58
7c25c1f to
00f57ec
Compare
m-kus
requested review from
Yoni-Starkware,
ittaysw and
noa-starkware
and removed request for
ittaysw
February 12, 2026 18:58
This was referenced Feb 12, 2026
This was referenced Feb 13, 2026
Yoni-Starkware
approved these changes
Feb 15, 2026
Yoni-Starkware
left a comment
Collaborator
There was a problem hiding this comment.
@Yoni-Starkware reviewed 25 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ittaysw, @m-kus, and @noa-starkware).
sdk/src/internal/private-transfers.ts line 76 at r1 (raw file):
// Blockifier requires base_block_number to be at least STORED_BLOCK_HASH_BUFFER (10) // blocks behind the current block, and the block must have a non-zero stored hash. const baseBlockNumber = currentBlockNumber > 10n ? currentBlockNumber - 10n : 1n;
Add a TODO to consider lowering this buffer to account for proving time.
Or add to some config? Do we have config for the SDK?
Code quote:
// Blockifier requires base_block_number to be at least STORED_BLOCK_HASH_BUFFER (10)
// blocks behind the current block, and the block must have a non-zero stored hash.
const baseBlockNumber = currentBlockNumber > 10n ? currentBlockNumber - 10n : 1n;
m-kus
force-pushed
the
02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation
branch
from
February 16, 2026 10:11
00f57ec to
be1ba75
Compare
m-kus
commented
Feb 16, 2026
m-kus
left a comment
Author
There was a problem hiding this comment.
@m-kus resolved 1 discussion.
Reviewable status: 24 of 25 files reviewed, all discussions resolved (waiting on @ittaysw, @noa-starkware, and @Yoni-Starkware).
m-kus
force-pushed
the
02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation
branch
2 times, most recently
from
February 16, 2026 10:30
4b137a4 to
3665155
Compare
m-kus
force-pushed
the
02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation
branch
from
February 16, 2026 10:35
3665155 to
a3204b6
Compare
m-kus
enabled auto-merge (squash)
February 16, 2026 10:36
m-kus
deleted the
02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation
branch
February 16, 2026 10:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Update starknet-devnet to custom fork with proof support
This PR updates the starknet-devnet dependency to use a custom fork that supports transaction proofs. The changes include:
APOLLO-PRE-PROOF-DEMO-11releasecontinue-on-errorflag from the TypeScript CI workflow now that devnet supports the required syscallsThe custom devnet fork includes a blockifier version that supports the new transaction version with proofs, enabling end-to-end testing of the proof validation flow.
This change is