Skip to content

fix: use patched devnet and mocked proof facts - #479

Merged
m-kus merged 1 commit into
mainfrom
02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation
Feb 16, 2026
Merged

m-kus merged 1 commit into
mainfrom
02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation

Conversation

@m-kus

@m-kus m-kus commented Feb 12, 2026 •

Copy link
Copy Markdown

Update starknet-devnet to custom fork with proof support

This PR updates the starknet-devnet dependency to use a custom fork that supports transaction proofs. The changes include:

  1. Replace asdf-based starknet-devnet installation with direct binary downloads from the custom fork's APOLLO-PRE-PROOF-DEMO-11 release
  2. Update GitHub workflows to use the custom devnet binary for CI tests
  3. Add detailed installation instructions in the README for developers
  4. Update the SDK to use the custom starknet.js fork that supports proof validation
  5. Add proof facts generation for on-chain transaction validation
  6. Update test fixtures to match the new devnet implementation
  7. Remove the continue-on-error flag from the TypeScript CI workflow now that devnet supports the required syscalls

The custom devnet fork includes a blockifier version that supports the new transaction version with proofs, enabling end-to-end testing of the proof validation flow.


This change is Reviewable

m-kus commented Feb 12, 2026 •

Copy link
Copy Markdown
Author

@m-kus
m-kus force-pushed the 02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation branch from a82df61 to 000f4e3 Compare February 12, 2026 12:55
@m-kus
m-kus marked this pull request as ready for review February 12, 2026 12:55
@m-kus
m-kus force-pushed the 02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation branch from 000f4e3 to 26e5c4d Compare February 12, 2026 17:44
@m-kus m-kus changed the title fix: use patched devnet, add contract feature to skip proof validation fix: use patched devnet and mocked proof facts Feb 12, 2026
@m-kus
m-kus force-pushed the 02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation branch 8 times, most recently from 7c25c1f to 00f57ec Compare February 12, 2026 18:58
@m-kus
m-kus requested review from Yoni-Starkware, ittaysw and noa-starkware and removed request for ittaysw February 12, 2026 18:58

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 25 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ittaysw, @m-kus, and @noa-starkware).


sdk/src/internal/private-transfers.ts line 76 at r1 (raw file):

      // Blockifier requires base_block_number to be at least STORED_BLOCK_HASH_BUFFER (10)
      // blocks behind the current block, and the block must have a non-zero stored hash.
      const baseBlockNumber = currentBlockNumber > 10n ? currentBlockNumber - 10n : 1n;

Add a TODO to consider lowering this buffer to account for proving time.
Or add to some config? Do we have config for the SDK?

Code quote:

      // Blockifier requires base_block_number to be at least STORED_BLOCK_HASH_BUFFER (10)
      // blocks behind the current block, and the block must have a non-zero stored hash.
      const baseBlockNumber = currentBlockNumber > 10n ? currentBlockNumber - 10n : 1n;

@m-kus
m-kus force-pushed the 02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation branch from 00f57ec to be1ba75 Compare February 16, 2026 10:11

@m-kus m-kus left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-kus resolved 1 discussion.
Reviewable status: 24 of 25 files reviewed, all discussions resolved (waiting on @ittaysw, @noa-starkware, and @Yoni-Starkware).

@m-kus
m-kus force-pushed the 02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation branch 2 times, most recently from 4b137a4 to 3665155 Compare February 16, 2026 10:30
@m-kus
m-kus force-pushed the 02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation branch from 3665155 to a3204b6 Compare February 16, 2026 10:35
@m-kus
m-kus enabled auto-merge (squash) February 16, 2026 10:36
@m-kus
m-kus merged commit 32f582c into main Feb 16, 2026
7 of 8 checks passed
@m-kus
m-kus deleted the 02-12-fix_use_patched_devnet_add_contract_feature_to_skip_proof_validation branch February 16, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants