Skip to content

feat(discovery-core): paginated incoming channel discovery with cursor support - #460

Merged
m-kus merged 1 commit into
mainfrom
pr-split/06-paginated-incoming
Feb 17, 2026
Merged

m-kus merged 1 commit into
mainfrom
pr-split/06-paginated-incoming

Conversation

@m-kus

@m-kus m-kus commented Feb 9, 2026 •

Copy link
Copy Markdown

Improved Channel Discovery API with Pagination Support

TL;DR

Refactored the incoming channels discovery API to support efficient pagination and batch fetching, while adding comprehensive documentation and cursor-based discovery.

What changed?

  • Added batch fetching of channels to reduce RPC calls
  • Simplified the IncomingChannel struct by removing redundant fields
  • Implemented discover_incoming_channels_paginated for cursor-based pagination
  • Added serialization support for the channel types
  • Improved documentation with usage examples and clearer function descriptions
  • Enhanced logging with debug and trace statements
  • Updated tests to cover the new functionality

This change is Reviewable

m-kus commented Feb 9, 2026 •

Copy link
Copy Markdown
Author

@m-kus
m-kus marked this pull request as ready for review February 9, 2026 19:37
@m-kus
m-kus force-pushed the pr-split/05-iobudget-cursors branch from ab8658c to 680b6bc Compare February 11, 2026 13:05
@m-kus
m-kus force-pushed the pr-split/06-paginated-incoming branch 2 times, most recently from 3a23638 to f0b6b73 Compare February 11, 2026 15:07
@m-kus
m-kus force-pushed the pr-split/05-iobudget-cursors branch from 680b6bc to 8cf9538 Compare February 11, 2026 15:07
@m-kus
m-kus requested a review from Yoni-Starkware February 11, 2026 15:08
@m-kus
m-kus force-pushed the pr-split/06-paginated-incoming branch from f0b6b73 to 88cd85e Compare February 11, 2026 16:08
@m-kus
m-kus force-pushed the pr-split/05-iobudget-cursors branch from 8cf9538 to 7d40aef Compare February 11, 2026 16:08
@m-kus
m-kus force-pushed the pr-split/05-iobudget-cursors branch from 7d40aef to ab28315 Compare February 11, 2026 19:10
@m-kus
m-kus force-pushed the pr-split/06-paginated-incoming branch from 88cd85e to cd78718 Compare February 11, 2026 19:10
@m-kus
m-kus changed the base branch from pr-split/05-iobudget-cursors to graphite-base/460 February 12, 2026 10:53

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @m-kus).

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @m-kus).

@m-kus
m-kus changed the base branch from pr-split/05-iobudget-cursors to graphite-base/460 February 16, 2026 10:38
@m-kus
m-kus force-pushed the pr-split/06-paginated-incoming branch from acf24fc to 33b03dd Compare February 16, 2026 12:43
@m-kus
m-kus force-pushed the graphite-base/460 branch from f30ad55 to 193a70c Compare February 16, 2026 12:43
@m-kus
m-kus changed the base branch from graphite-base/460 to pr-split/05-iobudget-cursors February 16, 2026 12:43
@m-kus
m-kus force-pushed the pr-split/06-paginated-incoming branch 3 times, most recently from 0b5f70f to 44013c2 Compare February 16, 2026 17:54
@m-kus
m-kus changed the base branch from pr-split/05-iobudget-cursors to graphite-base/460 February 17, 2026 12:15
@m-kus
m-kus force-pushed the graphite-base/460 branch from 193a70c to 8ec28e1 Compare February 17, 2026 12:18
@m-kus
m-kus force-pushed the pr-split/06-paginated-incoming branch from 44013c2 to 3fbd1e4 Compare February 17, 2026 12:18
@m-kus
m-kus changed the base branch from graphite-base/460 to main February 17, 2026 12:18
@m-kus
m-kus enabled auto-merge (squash) February 17, 2026 12:19
@m-kus
m-kus force-pushed the pr-split/06-paginated-incoming branch from 3fbd1e4 to 4417a95 Compare February 17, 2026 12:19
@m-kus
m-kus merged commit 50712b5 into main Feb 17, 2026
5 of 6 checks passed
@m-kus
m-kus deleted the pr-split/06-paginated-incoming branch February 17, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants