refactor(indexer): move devnet dump generation to a separate script, scaffold e2e tests dir

.claude/skills/pr-splitter/SKILL.md

@@ -153,7 +153,7 @@ cat .claude/pr-head-worktree/src/some_file.rs
 
 # See a specific file's diff
 awk '/^diff --git a\/src\/some_file.rs b\/src\/some_file.rs$/,/^diff --git /' \
-    .claude/pr-full.diff | head -n -1
+    .claude/pr-full.diff | sed '$ d'
 ```
 
 LLM reasoning is appropriate here: what each change does, which changes are
@@ -300,7 +300,7 @@ Quick version:
 ```bash
 # Extract one file's diff from the saved full diff
 awk '/^diff --git a\/src\/handler.rs b\/src\/handler.rs$/,/^diff --git /' \
-    .claude/pr-full.diff | head -n -1 > /tmp/handler.patch
+    .claude/pr-full.diff | sed '$ d' > /tmp/handler.patch
 
 # See the hunks
 grep '^@@' /tmp/handler.patch

.claude/skills/pr-splitter/partial-file-changes.md

@@ -15,7 +15,7 @@ slices still need it, use partial application for all slices except the last one
 
 ```bash
 awk '/^diff --git a\/path\/to\/file b\/path\/to\/file$/,/^diff --git /' \
-    .claude/pr-full.diff | head -n -1 > /tmp/file.patch
+    .claude/pr-full.diff | sed '$ d' > /tmp/file.patch
 ```
 
 Inspect hunks:

.claude/skills/pr-splitter/utility-patterns.md

@@ -37,15 +37,15 @@ awk -F'\t' '{print $1+$2, $3}' .claude/pr-numstat.tsv | sort -rn | head -20
 ```bash
 # Full diff for one file
 awk '/^diff --git a\/PATH b\/PATH$/,/^diff --git /' \
-    .claude/pr-full.diff | head -n -1
+    .claude/pr-full.diff | sed '$ d'
 
 # Hunk headers only (to see structure)
 awk '/^diff --git a\/PATH b\/PATH$/,/^diff --git /' \
     .claude/pr-full.diff | grep '^@@'
 
 # Specific hunks by number (1-indexed, keeps diff header)
 awk '/^diff --git a\/PATH b\/PATH$/,/^diff --git /' \
-    .claude/pr-full.diff | head -n -1 | \
+    .claude/pr-full.diff | sed '$ d' | \
     awk '/^@@/{n++} n==0 || n==1 || n==3'
 ```
 

.github/workflows/rust-ci.yaml

@@ -69,7 +69,7 @@ jobs:
         if: github.event_name == 'push' || steps.cairo-check.outputs.changed == 'true'
         uses: software-mansion/setup-scarb@v1
         with:
-          scarb-version: "2.15.0"
+          scarb-version: "2.15.1"
       - name: Install starknet-foundry and starknet-devnet via asdf
         if: github.event_name == 'push' || steps.cairo-check.outputs.changed == 'true'
         uses: asdf-vm/actions/install@v3
@@ -81,6 +81,7 @@ jobs:
         if: github.event_name == 'push' || steps.cairo-check.outputs.changed == 'true'
         run: |
           cd sdk
+          npm run scarb:build
           npm run generate:cairo-refs
           cp tests/fixtures/cairo-reference-data.json ../crates/discovery-core/tests/fixtures/cairo-reference-data.json
 

.github/workflows/typescript-ci.yml

@@ -33,7 +33,7 @@ jobs:
       - name: Install Scarb
         uses: software-mansion/setup-scarb@v1
         with:
-          scarb-version: "2.15.0"
+          scarb-version: "2.15.1"
 
       - name: Install starknet-foundry via asdf
         uses: asdf-vm/actions/install@v3
@@ -68,7 +68,7 @@ jobs:
       - name: Install Scarb
         uses: software-mansion/setup-scarb@v1
         with:
-          scarb-version: "2.15.0"
+          scarb-version: "2.15.1"
 
       - name: Install starknet-devnet via asdf
         uses: asdf-vm/actions/install@v3
@@ -80,7 +80,7 @@ jobs:
         run: npm ci
 
       - name: Build Cairo contracts
-        run: scarb build
+        run: npm run scarb:build
 
       - name: Run devnet tests
         run: npm run test:devnet

crates/discovery-core/tests/fixtures/devnet-state.json

@@ -1,5 +1,5 @@
 {
-  "_comment": "Devnet storage dump for Rust discovery tests. Regenerate by running SDK devnet tests with DUMP_STATE_PATH set.",
+  "_comment": "Devnet storage dump for Rust discovery tests. Regenerate with: cd e2e && npm run generate-dump",
   "constants": {
     "contract_address": "0x2af189f2f77758dacd689baf7d0166e65b03f25be65f54f7d131b9cc8a0438d",
     "alice_address": "0x34ba56f92265f0868c57d3fe72ecab144fc96f97954bbbc4252cef8e8a979ba",
@@ -10,52 +10,53 @@
     "eth_token": "0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7",
     "strk_token": "0x4718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d"
   },
-  "block": 5,
+  "block": 6,
   "slots": {
-    "0x145860488339af4c45f0085e66a70617fb7411d299e0418163195b9641a9828": "0x3e615638e0b79444a70f8c695bf8f2a47033bf1cf95691ec3130f64939cee99",
-    "0x675fe956fdd281705b9f422743ff351ec886bee0d59c21556f039d9e4d5c001": "0x26bd110619d11cfdfc28e281df893bc24828e89177318e9dbd860cdaedeb6b3",
     "0x3c0ba99f1a18bcdc81fcbcb6b4f15a9a6725f937075aed6fac107ffcb147068": "0x1",
-    "0x5471bb93b2a05646d87e41f8fb7039ba36a43da1957aee350ed793c21d6ef94": "0x1",
-    "0x39750ebce9127dd81b0a39b625234ba6e1481527bb56a40c11f3a942c6716e7": "0x26bd110619d11cfdfc28e281df893bc24828e89177318e9dbd860cdaedeb6b3",
-    "0x34a44171b22cb2e8cd7fee8ef4933a64583d5b87430b41fcd9a0cc51bab4b20": "0x1",
-    "0x25e8088c2025e3b546ab067a53a231a34b6368597c5248bcb7628903ed1cb52": "0x3e615638e0b79444a70f8c695bf8f2a47033bf1cf95691ec3130f64939cee99",
-    "0x4f9c163f4caf315f8ce4869a1d6227a5dfa05731f83e2bcb14d7a4c061e7fe7": "0x3e615638e0b79444a70f8c695bf8f2a47033bf1cf95691ec3130f64939cee99",
-    "0x447dbadc22f4aaec901a1d97f3ba76a1052d4ee64dc1b302bed245d70910b98": "0x3711c9d994faf6055172091cb841fd4831aa743e6f3315163b06a122c841846",
     "0x19241d223519f013e4db3aaf8a1a67fd7e44e4ff8764ac686c57f1014047923": "0x3711c9d994faf6055172091cb841fd4831aa743e6f3315163b06a122c841846",
-    "0x343dfcaa63b03b34a4dc1a0303067e9727ce519478f11e9aa586f55cef98689": "0x26bd110619d11cfdfc28e281df893bc24828e89177318e9dbd860cdaedeb6b3",
     "0xf8612cacb74429aab92a1b3e95db91c6a0c6e6436b0777064ed21bb4ecb0ed": "0x1",
-    "0x3bc73a5b8cdf1fc3762b454d423f43427687a625f3248bf91df99c8ab34da59": "0x3e615638e0b79444a70f8c695bf8f2a47033bf1cf95691ec3130f64939cee99",
-    "0x26d7fc4b2c02d678e0c3dcc1c4805c46095efef612a4f6b131c74262b46c871": "0x3711c9d994faf6055172091cb841fd4831aa743e6f3315163b06a122c841846",
+    "0x25e8088c2025e3b546ab067a53a231a34b6368597c5248bcb7628903ed1cb52": "0x3e615638e0b79444a70f8c695bf8f2a47033bf1cf95691ec3130f64939cee99",
+    "0x34a44171b22cb2e8cd7fee8ef4933a64583d5b87430b41fcd9a0cc51bab4b20": "0x1",
+    "0x447dbadc22f4aaec901a1d97f3ba76a1052d4ee64dc1b302bed245d70910b98": "0x3711c9d994faf6055172091cb841fd4831aa743e6f3315163b06a122c841846",
+    "0x675fe956fdd281705b9f422743ff351ec886bee0d59c21556f039d9e4d5c001": "0x26bd110619d11cfdfc28e281df893bc24828e89177318e9dbd860cdaedeb6b3",
     "0x62ae2cfa69d93aaaa82aa1b793ca044a7d1f7e50ad57265b0a07e7a458f030d": "0x1",
+    "0x26d7fc4b2c02d678e0c3dcc1c4805c46095efef612a4f6b131c74262b46c871": "0x3711c9d994faf6055172091cb841fd4831aa743e6f3315163b06a122c841846",
+    "0x5471bb93b2a05646d87e41f8fb7039ba36a43da1957aee350ed793c21d6ef94": "0x1",
+    "0x3bc73a5b8cdf1fc3762b454d423f43427687a625f3248bf91df99c8ab34da59": "0x3e615638e0b79444a70f8c695bf8f2a47033bf1cf95691ec3130f64939cee99",
+    "0x343dfcaa63b03b34a4dc1a0303067e9727ce519478f11e9aa586f55cef98689": "0x26bd110619d11cfdfc28e281df893bc24828e89177318e9dbd860cdaedeb6b3",
+    "0x39750ebce9127dd81b0a39b625234ba6e1481527bb56a40c11f3a942c6716e7": "0x26bd110619d11cfdfc28e281df893bc24828e89177318e9dbd860cdaedeb6b3",
+    "0x145860488339af4c45f0085e66a70617fb7411d299e0418163195b9641a9828": "0x3e615638e0b79444a70f8c695bf8f2a47033bf1cf95691ec3130f64939cee99",
+    "0x4f9c163f4caf315f8ce4869a1d6227a5dfa05731f83e2bcb14d7a4c061e7fe7": "0x3e615638e0b79444a70f8c695bf8f2a47033bf1cf95691ec3130f64939cee99",
+    "0x379e8500fa24fa25f718174430d31f5e26efae5ca7f9746e2ba0a7ba23682ac": "0x76b8c7f44d419d9bf013c56ba74799b5055b35893bc29b1cef7eb1e834cc040",
     "0x379e8500fa24fa25f718174430d31f5e26efae5ca7f9746e2ba0a7ba23682ab": "0x1",
-    "0x379e8500fa24fa25f718174430d31f5e26efae5ca7f9746e2ba0a7ba23682ac": "0x3d39b267cacff3efa41fd63d7a62b91b2cda5ed3707fab5dcfb3e71730e6f46",
     "0x5edfcc8f06227313126c1e9dc8e05b63f6e0be07034c9b309b6f6d3a8422163": "0x7c53034b6dea7afaa4ff6317dbf852a6ee8cb88391194e36efaaef406373da4",
-    "0x379e8500fa24fa25f718174430d31f5e26efae5ca7f9746e2ba0a7ba23682ad": "0x4a70ec5bfcbe40fb106c7448eeba3a1814f01bb62738b18e34e54dd206b025f",
-    "0x2fc83002bf5a013133e268d023531d33b190144c5b1239465caa2c99f017d25": "0x1",
-    "0x6b701cacf6618c2f53e8738f28e5bd34c91c907f089f8505d2616f39ca34dfe": "0x1",
-    "0x8c919011215bafdb77dd3554171499e8d88e3e9377e24996d6a52def26e97": "0x65a726f01770b19ff9d6c6b69bc2b5dc4e405d71398ceaa7d0d8fa7b2d53e7b",
-    "0x3b201a5dd5bde7e1b8f016c1277b1b0ac26e29637600cada1c27c65d1a4e4ee": "0x6bd0276cf6bae25f911d6fd9b515112c865fefac0f5a85f1ce6f204c24dfae8",
+    "0x379e8500fa24fa25f718174430d31f5e26efae5ca7f9746e2ba0a7ba23682ad": "0x74a19912d70b11eff57532b619ede58dde9063399a9002c28faa10f2849f0ce",
+    "0x9af47cfba5e6d9ebf4baba7e529e15096aed25234b4a7defdbfbd1d904bc00": "0x4f83070db8b56daeb56ca56abce8c5cafac432cf4055e8f706c18d9c698e6e",
+    "0x3c4e1600fd612575abb99758b3d97e553879841fdf9cf2d9ed8c1c025723d44": "0x7913e4dbbc06e873598f6e0bb0076449079fbdd951650c7f7a258d1c6b6a82d",
     "0x7b007270125cd57751a5af44f643ee9c0cfd05d124df2ce52cdd7b51ccc6412": "0x1",
-    "0x7b007270125cd57751a5af44f643ee9c0cfd05d124df2ce52cdd7b51ccc6413": "0x6e026c696bd6a283596a14d75c11ac5cfa5d6de5c5612d63c0ba0d1c406cd90",
-    "0x5003f5276fd4d1a5150571f54551bdd8ace4884c9c218896b8c7b96bb089742": "0x3320e456dfb5c86d8f79377ab0e3394b26ecd0dd8753694b56e6d38d956798f",
-    "0x5003f5276fd4d1a5150571f54551bdd8ace4884c9c218896b8c7b96bb089743": "0x4e0aa260d9ddd7d4599f979987771dbe14163190f197a3c9f00c4eebe5486aa",
-    "0x7b007270125cd57751a5af44f643ee9c0cfd05d124df2ce52cdd7b51ccc6414": "0x129ba94f8784a86b30ca2e0913e63f80e9c5c63cb0fcf540098b53c0a611cb2",
-    "0x5eb8c2889287ec0461d826776d00817bc5dfa4334acdaef61af6f4660ded18a": "0x1",
-    "0x72d080c3472770b49a6c53ca26f67511fd2a645fe33dc116d11764c15e75c61": "0xb68a8ee91087546a333536c30039f58a3ac466af90e913873800f93bbc61ff",
-    "0x6f444cb92479abe0d7d2a2e305a4c2ab1020333adc71db669b93706137f3b40": "0x76603957aa668537460322afa2c13d61f3a0784a726406a603f4cfa74d6ffd8",
-    "0x3b201a5dd5bde7e1b8f016c1277b1b0ac26e29637600cada1c27c65d1a4e4ef": "0x1ee2913b3ab08b75c743907d5cadffe5e5130ef74e22b2b6efc95acc787738d",
+    "0x5003f5276fd4d1a5150571f54551bdd8ace4884c9c218896b8c7b96bb089742": "0x57fa47d04a03a08ace9ec9e4c08df2a836ddf0dda0ee08d5d071778b392e2fb",
     "0x39c697c748137a6b21a1cd516f2442e8dfe2b3d3002c04c9df0a815381e3c81": "0x1",
-    "0x52b584ea1eefc2f77a33d944db5b408429c95d724f16feeb4c58b885f9e9a5": "0x1",
-    "0x6f444cb92479abe0d7d2a2e305a4c2ab1020333adc71db669b93706137f3b41": "0x1c34e015cbb3b0f1f8e9297f1f474d741fcaef07e9458be4384fb50d924a864",
-    "0x3b201a5dd5bde7e1b8f016c1277b1b0ac26e29637600cada1c27c65d1a4e4f0": "0x58e08e245a5bb25961dddc315c7eb4bb8c06111e774719d4c4a56e0701cfccf",
-    "0x47bd4a7734d20c919cffb3b1508a20b33e112c1dd314600e3177d07a55fc820": "0xe89707a843484b33e58a87eb76ce16979237d1f610386eb29e5e12b63cf63d",
-    "0x8c919011215bafdb77dd3554171499e8d88e3e9377e24996d6a52def26e96": "0x55b24eeec617818ebf516ac355c9a441ae5e59bcd8c52ea65b73bdf7957cf6d",
+    "0x3b201a5dd5bde7e1b8f016c1277b1b0ac26e29637600cada1c27c65d1a4e4ee": "0x5853ba3b20cb1cd047cb20cd7dc4a808bfd6658e0b7dac5a9b179a021b83367",
+    "0x34acc712e95a859fc17699fc81a191f9ec885ab5d587a4d4d00bb4fcb5e73c0": "0x7d66476b004539be9cfbe742fee8069a963018adc48d1d34cbacbfec3244472",
+    "0x6f444cb92479abe0d7d2a2e305a4c2ab1020333adc71db669b93706137f3b41": "0x13fbb7c2572f2d218f7be2657e1906ecce6caa3c4b569f8525f8758f805166",
+    "0x5003f5276fd4d1a5150571f54551bdd8ace4884c9c218896b8c7b96bb089743": "0x22d0a06c572c2c909eb0a4743920a52562105fe8ebb979c03ee6d5a55ad5daf",
+    "0x8c919011215bafdb77dd3554171499e8d88e3e9377e24996d6a52def26e97": "0x6eeeaaf08fe393fb5a46ff00061f2c80325ea54f32700f5b94c09f9378891e4",
+    "0x34acc712e95a859fc17699fc81a191f9ec885ab5d587a4d4d00bb4fcb5e73c1": "0x7a72d1717ed83ec46f16f5054fe50003808329807a00ecbe19459bf7594e5cf",
     "0x1ea274a11911678e614de72ecb6a747a22a01c0517b7ac424f3e7020c016d4b": "0x1",
-    "0x3c4e1600fd612575abb99758b3d97e553879841fdf9cf2d9ed8c1c025723d44": "0x7913e4dbbc06e873598f6e0bb0076449079fbdd951650c7f7a258d1c6b6a82d",
-    "0x34acc712e95a859fc17699fc81a191f9ec885ab5d587a4d4d00bb4fcb5e73c1": "0x3e834790a84c935398f25697273b6e9b218567d296722cad328c3c0c64c4318",
-    "0x8c919011215bafdb77dd3554171499e8d88e3e9377e24996d6a52def26e98": "0x6d34cec76e786641e9a5de87f15a9d1a520da1ae932870a003b16f0859d3be1",
-    "0x34acc712e95a859fc17699fc81a191f9ec885ab5d587a4d4d00bb4fcb5e73c0": "0x3f0b0d6b3b5912d2094195d06d293691ac62e9f586f6d21cac4dae59dd49016",
-    "0x9af47cfba5e6d9ebf4baba7e529e15096aed25234b4a7defdbfbd1d904bc00": "0x1da7a0edf47109a1e000808c6661cf92d8be5981eedcc1b02edbca9f0e4fd34",
-    "0x9af47cfba5e6d9ebf4baba7e529e15096aed25234b4a7defdbfbd1d904bc01": "0x778f02681e02678eddcf97a07daf68131fe0ca20f44da6c80946f9f7a7dfedf"
+    "0x47bd4a7734d20c919cffb3b1508a20b33e112c1dd314600e3177d07a55fc820": "0x1caefeeab3b2d2551c1252ac158314726268a542cca983dbf9510a0ba50e3d",
+    "0x3b201a5dd5bde7e1b8f016c1277b1b0ac26e29637600cada1c27c65d1a4e4ef": "0x42bf7039cfb59aa332343606c3bcc6d3001e68be6becbb0dcc71e91efa50366",
+    "0x2fc83002bf5a013133e268d023531d33b190144c5b1239465caa2c99f017d25": "0x1",
+    "0x7b007270125cd57751a5af44f643ee9c0cfd05d124df2ce52cdd7b51ccc6414": "0x3f8f51973accd1ac70cc797b90b632b5c3c2c953576a9479014ae3aae1881e2",
+    "0x52b584ea1eefc2f77a33d944db5b408429c95d724f16feeb4c58b885f9e9a5": "0x1",
+    "0x8c919011215bafdb77dd3554171499e8d88e3e9377e24996d6a52def26e98": "0x7cf0bb29adb97073905d069f50a420f6404a318d1f9e529e4d27d499d52219c",
+    "0x5eb8c2889287ec0461d826776d00817bc5dfa4334acdaef61af6f4660ded18a": "0x1",
+    "0x3b201a5dd5bde7e1b8f016c1277b1b0ac26e29637600cada1c27c65d1a4e4f0": "0x46337a1cb2d2409107a53092b534cdb58e0ef60344febfc5d8f7132fe51741e",
+    "0x7b007270125cd57751a5af44f643ee9c0cfd05d124df2ce52cdd7b51ccc6413": "0x6d521928b81e0543b9e8305eab68f0a278af23ee7be7f659efba519949f9db3",
+    "0x72d080c3472770b49a6c53ca26f67511fd2a645fe33dc116d11764c15e75c61": "0xf6dd4f242382c01a61bc1e398f0e1eb6f837bb23f67921b55051a2d16b25bc",
+    "0x8c919011215bafdb77dd3554171499e8d88e3e9377e24996d6a52def26e96": "0x65381b84e427379170f3095d637ae58620069e76326bbaccae0cddb0308f41f",
+    "0x6f444cb92479abe0d7d2a2e305a4c2ab1020333adc71db669b93706137f3b40": "0x670ca9f6e6f882172007b42e3e335b59772e267c054a5b95f3db85f1b131ec4",
+    "0x9af47cfba5e6d9ebf4baba7e529e15096aed25234b4a7defdbfbd1d904bc01": "0x4ff328709575df83c8626300826eb20c441183c7f70aeb2d5dee602247582f1",
+    "0x6b701cacf6618c2f53e8738f28e5bd34c91c907f089f8505d2616f39ca34dfe": "0x1",
+    "0x68b096457d951aa342cf8b0ad600961426508a9383e5591a7f376121c4e60f7": "0x1"
   }
-}
+}

e2e/eslint.config.js

@@ -0,0 +1,27 @@
+import eslint from "@eslint/js";
+import tseslint from "typescript-eslint";
+
+export default tseslint.config(
+  eslint.configs.recommended,
+  ...tseslint.configs.recommended,
+  {
+    ignores: ["node_modules/**", "eslint.config.js"],
+  },
+  {
+    languageOptions: {
+      parserOptions: {
+        project: "./tsconfig.json",
+      },
+    },
+    rules: {
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          argsIgnorePattern: "^_",
+        },
+      ],
+      "@typescript-eslint/no-explicit-any": "warn",
+      "@typescript-eslint/no-floating-promises": "error",
+    },
+  }
+);