starknet_transaction_prover: cover the CORS layer attachment in start_server - #15036
Draft
avi-starkware wants to merge 1 commit into
Draft
starknet_transaction_prover: cover the CORS layer attachment in start_server#15036avi-starkware wants to merge 1 commit into
avi-starkware wants to merge 1 commit into
Conversation
This was referenced Aug 25, 2026
|
This change is |
Collaborator
Author
This was referenced Aug 25, 2026
avi-starkware
force-pushed
the
avi/privacy/server-cors-wiring-test
branch
from
August 25, 2026 20:01
5086e78 to
971cbc1
Compare
avi-starkware
force-pushed
the
avi/privacy/rpc-impl-overload-tests
branch
from
August 25, 2026 20:01
a271bfa to
079a479
Compare
…_server start_server takes cors_layer as an Option and threads it into the middleware stack, but no test drove that argument: dropping it would have disabled CORS on a configured deployment with the suite still green. Adds the positive case and its mirror (no layer configured, no header), so neither can pass on a response that carries the header unconditionally.
avi-starkware
force-pushed
the
avi/privacy/server-cors-wiring-test
branch
from
August 26, 2026 05:50
971cbc1 to
8a0ec9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start_server takes cors_layer as an Option and threads it into the
middleware stack, but no test drove that argument: dropping it would
have disabled CORS on a configured deployment with the suite still
green.
Adds the positive case and its mirror (no layer configured, no header),
so neither can pass on a response that carries the header
unconditionally.