starknet_transaction_prover: unit-test the JSON-RPC error mapping - #15034
Draft
avi-starkware wants to merge 1 commit into
Draft
starknet_transaction_prover: unit-test the JSON-RPC error mapping#15034avi-starkware wants to merge 1 commit into
avi-starkware wants to merge 1 commit into
Conversation
This was referenced Aug 25, 2026
|
This change is |
Collaborator
Author
This was referenced Aug 25, 2026
runner_error_to_rpc had no test module, so nothing pinned the rule that upstream Starknet application errors (non-negative codes) are forwarded verbatim while JSON-RPC infrastructure errors (negative codes) collapse into -32603. Inverting that condition kept every test green. Covers both sides of the split, the i32 overflow fallback, the out-of-gas hint keeping the upstream revert reason, and the pending-block and validation-error mappings.
avi-starkware
force-pushed
the
avi/privacy/errors-unit-tests
branch
from
August 25, 2026 20:01
0f4e357 to
d987c0b
Compare
avi-starkware
force-pushed
the
avi/privacy/deployment-docs-and-smoke-v2
branch
from
August 25, 2026 20:01
7678bbf to
583f17f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runner_error_to_rpc had no test module, so nothing pinned the rule that
upstream Starknet application errors (non-negative codes) are forwarded
verbatim while JSON-RPC infrastructure errors (negative codes) collapse
into -32603. Inverting that condition kept every test green.
Covers both sides of the split, the i32 overflow fallback, the out-of-gas
hint keeping the upstream revert reason, and the pending-block and
validation-error mappings.