Skip to content

starknet_transaction_prover: add manual testing guide - #14404

Open
avi-starkware wants to merge 1 commit into
avi/privacy/drop-stale-dead-code-allowfrom
avi/privacy/manual-testing-guide-v2
Open

starknet_transaction_prover: add manual testing guide#14404
avi-starkware wants to merge 1 commit into
avi/privacy/drop-stale-dead-code-allowfrom
avi/privacy/manual-testing-guide-v2

Conversation

@avi-starkware

@avi-starkware avi-starkware commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Adds the deep-dive manual testing guide for the prover service — endpoints,
negative flows, the CORS matrix, compression, concurrency, load, TLS, OHTTP,
body-size limits, env-var config and observability.

Split out of #14052 so that PR stays focused on the smoke script and its
checklist, both of which reference this document for manual reproduction.

Two sections are stubs pointing at unit tests rather than manual steps: origin
normalization and incomplete-TLS-config startup are both gated by
server/cors_test.rs and server/config_test.rs, so restarting a pod to
re-check them by hand proves nothing CI has not already proven.

This is the longest PR in the stack and reads as reference material rather than
code — most of it is copy-paste curl/jq blocks per check.

@cursor

cursor Bot commented Jun 7, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation-only change with no runtime or service behavior modifications.

Overview
Adds MANUAL_TESTING_GUIDE.md, a full manual validation playbook for deployed starknet_transaction_prover services, and points quick smoke checks to DEPLOYMENT_SMOKE_TESTING_GUIDE.md.

The guide documents setup (env vars, ConfigMap/CLI config), shell helpers to pull real chain txs, and copy-paste curl/jq checks for /health, starknet_specVersion, and starknet_proveTransaction (happy path and expected error codes).

It also covers CORS, HTTP compression, concurrency (-32005), load testing (vegeta/hey), optional TLS and OHTTP, request body size limits, env-var config, and observability expectations.

Origin normalization and incomplete TLS config at startup are explicitly deferred to unit tests (cors_test.rs, config_test.rs). Section 15 adds a PASS/FAIL/SKIP results template for deployment PRs.

Reviewed by Cursor Bugbot for commit 9b3f384. Bugbot is set up for automated code reviews on this repo. Configure here.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions Bot added the stale label Jul 8, 2026
@avi-starkware
avi-starkware changed the base branch from avi/privacy/exhaustive-error-spec-test-v2 to graphite-base/14404 July 9, 2026 11:47
@avi-starkware
avi-starkware force-pushed the graphite-base/14404 branch from dd1dfa1 to f25baca Compare July 9, 2026 11:48
@avi-starkware
avi-starkware force-pushed the avi/privacy/manual-testing-guide-v2 branch from 7a48fbc to b0918fa Compare July 9, 2026 11:48
@avi-starkware
avi-starkware changed the base branch from graphite-base/14404 to avi/privacy/drop-stale-dead-code-allow July 9, 2026 11:48
@avi-starkware
avi-starkware force-pushed the avi/privacy/drop-stale-dead-code-allow branch from f25baca to d42f341 Compare July 9, 2026 13:03
@avi-starkware
avi-starkware force-pushed the avi/privacy/manual-testing-guide-v2 branch from b0918fa to ad88f40 Compare July 9, 2026 13:03

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ad88f40. Configure here.

Comment thread crates/starknet_transaction_prover/MANUAL_TESTING_GUIDE.md Outdated
@avi-starkware
avi-starkware force-pushed the avi/privacy/drop-stale-dead-code-allow branch from d42f341 to db1c0cc Compare July 9, 2026 13:57
@avi-starkware
avi-starkware force-pushed the avi/privacy/manual-testing-guide-v2 branch from ad88f40 to 5ed8f8a Compare July 9, 2026 13:57
@github-actions github-actions Bot removed the stale label Jul 10, 2026
@avi-starkware
avi-starkware force-pushed the avi/privacy/manual-testing-guide-v2 branch from 5ed8f8a to 663bac2 Compare July 12, 2026 10:09
@avi-starkware
avi-starkware force-pushed the avi/privacy/drop-stale-dead-code-allow branch from db1c0cc to a47a44f Compare July 12, 2026 10:09
@avi-starkware
avi-starkware force-pushed the avi/privacy/manual-testing-guide-v2 branch from 663bac2 to 7229c36 Compare July 12, 2026 12:39
@avi-starkware
avi-starkware force-pushed the avi/privacy/drop-stale-dead-code-allow branch from a47a44f to a53578d Compare July 12, 2026 12:39
@avi-starkware
avi-starkware force-pushed the avi/privacy/drop-stale-dead-code-allow branch from a53578d to c86edbd Compare July 19, 2026 13:25
@avi-starkware
avi-starkware force-pushed the avi/privacy/drop-stale-dead-code-allow branch from 4fceaa9 to b7a55f5 Compare August 25, 2026 20:01
@avi-starkware
avi-starkware force-pushed the avi/privacy/manual-testing-guide-v2 branch from 9ec7826 to 9b3f384 Compare August 25, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants