starknet_transaction_prover: unit-test both overload-rejection paths - #15035
Draft
avi-starkware wants to merge 1 commit into
Draft
starknet_transaction_prover: unit-test both overload-rejection paths#15035avi-starkware wants to merge 1 commit into
avi-starkware wants to merge 1 commit into
Conversation
This was referenced Aug 25, 2026
|
This change is |
This was referenced Aug 25, 2026
Collaborator
Author
rpc_impl.rs had no test module, so neither -32005 path was exercised: service_busy appeared only as a spec-conformance sample, never through the real admission logic. Both paths return the same code, so each test also asserts its own log line and the absence of the other's. Without that, removing the admission cap left the queue-full test passing via the queue-wait timeout instead.
avi-starkware
force-pushed
the
avi/privacy/errors-unit-tests
branch
from
August 25, 2026 20:01
0f4e357 to
d987c0b
Compare
avi-starkware
force-pushed
the
avi/privacy/rpc-impl-overload-tests
branch
from
August 25, 2026 20:01
a271bfa to
079a479
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rpc_impl.rs had no test module, so neither -32005 path was exercised:
service_busy appeared only as a spec-conformance sample, never through
the real admission logic.
Both paths return the same code, so each test also asserts its own log
line and the absence of the other's. Without that, removing the
admission cap left the queue-full test passing via the queue-wait
timeout instead.