starknet_transaction_prover: add ServiceConfig validation tests - #14049
starknet_transaction_prover: add ServiceConfig validation tests#14049avi-starkware wants to merge 1 commit into
Conversation
PR SummaryLow Risk Overview New coverage pins required CORS wiring tests are slimmed down so Reviewed by Cursor Bugbot for commit 6445447. Bugbot is set up for automated code reviews on this repo. Configure here. |
3bf5954 to
8600ded
Compare
8aa40a1 to
b5dba94
Compare
8600ded to
96bf8d9
Compare
9636c86 to
20c98e9
Compare
96bf8d9 to
056f406
Compare
20c98e9 to
d437078
Compare
056f406 to
3a5608b
Compare
d437078 to
8342ce5
Compare
3a5608b to
38dd27c
Compare
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
38dd27c to
f899d6c
Compare
8342ce5 to
44f2584
Compare
44f2584 to
f05b07f
Compare
5584d93 to
95ab04d
Compare
f05b07f to
44eccac
Compare
95ab04d to
dde27e4
Compare
31f18eb to
bef2115
Compare
dde27e4 to
68f6fc1
Compare
bef2115 to
b5aa7f0
Compare
68f6fc1 to
474fba7
Compare
b5aa7f0 to
c86b17e
Compare
474fba7 to
591cf1b
Compare
Adds unit tests for ServiceConfig::from_args covering: missing rpc_url rejection, zero max_concurrent_requests / max_connections rejection, mutual exclusion of --no-cors and --cors-allow-origin, --no-cors clearing config-file origins, --skip-fee-field-validation propagating to ProverConfig, config-file values being used when CLI flags are absent, CLI flags overriding config-file values, and additional CORS scheme/userinfo rejection at the config layer.
c86b17e to
c9610b9
Compare
591cf1b to
6445447
Compare

Adds unit tests for
ServiceConfig::from_args: missingrpc_url, zeromax_concurrent_requests/max_connections, mutual exclusion of--no-corsand
--cors-allow-origin,--no-corsclearing config-file origins,--skip-fee-field-validationreachingProverConfig, config-file values usedwhen CLI flags are absent, and CLI flags overriding config-file values.
The CORS cases here cover only the wiring — that
from_argsroutes originsthrough
normalize_cors_allow_originsand propagates its rejection — pluswildcard_ignores_invalid, which has no counterpart at the other layer.cors_test.rs(#14048) owns the normalization matrix itself; duplicating it heremeant two places to update for one behaviour.
tls_config_validationloses a case column that wasNonein every case, andgains the shape it was evidently there for: a config file supplying
tls_cert_filewith no CLI key, which the CLI-only cases cannot express.