Skip to content

Remove direct physcons module dependencies from C3 - #4

Open
scrasmussen wants to merge 1 commit into
ufs-community:mainfrom
scrasmussen:c3-remove-physcons
Open

Remove direct physcons module dependencies from C3#4
scrasmussen wants to merge 1 commit into
ufs-community:mainfrom
scrasmussen:c3-remove-physcons

Conversation

@scrasmussen

Copy link
Copy Markdown

Description:

  • Removes direct dependencies on the global physcons module from CCPP physics schemes.
  • Supplies physical constants through explicit CCPP arguments, with standard names, units, and metadata.
  • Makes each scheme’s required constants visible in its interface instead of relying on hidden module state.
  • Improves portability and reuse of physics schemes in different host models and configurations.
  • Simplifies dependency tracking, testing, and maintenance by centralizing ownership of physical constants in the host/CCPP framework.

Related PRs

@grantfirl grantfirl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that keeping the physcons import statement was an oversight since the actual constants data was already being passed in via the argument list.

@lisa-bengtsson

Copy link
Copy Markdown
Collaborator

I'm guessing that keeping the physcons import statement was an oversight since the actual constants data was already being passed in via the argument list.

yes, my fault. Thanks for cleaning it up @scrasmussen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants