Remove direct physcons module dependencies from C3 - #4
Open
scrasmussen wants to merge 1 commit into
Open
Conversation
This was referenced Aug 15, 2026
Open
scrasmussen
force-pushed
the
c3-remove-physcons
branch
from
August 18, 2026 16:48
37a93ed to
a1645fb
Compare
grantfirl
approved these changes
Aug 26, 2026
grantfirl
left a comment
There was a problem hiding this comment.
I'm guessing that keeping the physcons import statement was an oversight since the actual constants data was already being passed in via the argument list.
Collaborator
yes, my fault. Thanks for cleaning it up @scrasmussen ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related PRs