Remove direct physcons module dependencies from CCPP-Physics - #1235
Open
scrasmussen wants to merge 234 commits into
Open
Remove direct physcons module dependencies from CCPP-Physics#1235scrasmussen wants to merge 234 commits into
scrasmussen wants to merge 234 commits into
Conversation
…emove *_of_new_state (default name refers to 'current' value)
…medmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post
- Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials.
…' into feature/tendency_cleanup
…_dimension in GFS_time_vary_pre.scm
…endency paradigm; cleanup saving of states no longer needed
…as removed recently
- fpkapx function called before gfuncphys initializes its runtime constants, manually porting function
scrasmussen
requested review from
andrewgettelman,
areinecke,
climbfuji,
dustinswales,
grantfirl,
haiqinli,
lisa-bengtsson,
matusmartini,
mdtoyNOAA,
mjiacono,
rhaesung and
tanyasmirnova
as code owners
August 15, 2026 19:36
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
UFSWM - Remove direct physcons module dependencies from CCPP-Physics ufs-community/ufs-weather-model#3323
SCM - Remove references to physcons module from SCM ccpp-scm#653
Description of Changes:
Tests Conducted: