Remove direct physcons module dependencies from MYNN - #32
Open
scrasmussen wants to merge 1 commit into
Open
Conversation
This was referenced Aug 15, 2026
Open
- OpenACC correctness fixes two present-list corrections are separate
scrasmussen
force-pushed
the
mynn-sfc-remove-physcons
branch
from
August 18, 2026 16:50
6664687 to
642bf38
Compare
grantfirl
reviewed
Aug 26, 2026
| real(kind_phys), parameter :: ep3 = 1.-ep2 | ||
| real(kind_phys), parameter :: g_inv = 1.0/grav | ||
| real(kind_phys), parameter :: rvovrd = Rv/Rd | ||
| real(kind_phys) :: cp = 1.0E30_kind_phys |
There was a problem hiding this comment.
Same question RE: initializing to 1000.0 as in the physics PR
grantfirl
reviewed
Aug 26, 2026
| !$acc QSFC_lnd, QSFC_wat, QSFC_ice, & | ||
| !$acc U10, V10, U1D, V1D, U1D2, V1D2, & | ||
| !$acc ZNTstoch_lnd, ZNTstoch_lnd, ZNTstoch_ice, & | ||
| !$acc ZNTstoch_lnd, ZNTstoch_wat, ZNTstoch_ice, & |
There was a problem hiding this comment.
Ha. Nice catches. Were these caught with an AI tool or something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related PRs