Skip to content

Remove direct physcons module dependencies from CCPP-Physics - #1131

Open
scrasmussen wants to merge 4 commits into
NOAA-EMC:developfrom
scrasmussen:ufs-dev-rm-ccpp-physcons
Open

Remove direct physcons module dependencies from CCPP-Physics#1131
scrasmussen wants to merge 4 commits into
NOAA-EMC:developfrom
scrasmussen:ufs-dev-rm-ccpp-physcons

Conversation

@scrasmussen

Copy link
Copy Markdown
Contributor

Description

  • Removes direct dependencies on the global physcons module from CCPP physics schemes.
  • Supplies physical constants through explicit CCPP arguments, with standard names, units, and metadata.
  • Makes each scheme’s required constants visible in its interface instead of relying on hidden module state.
  • Improves portability and reuse of physics schemes in different host models and configurations.
  • Simplifies dependency tracking, testing, and maintenance by centralizing ownership of physical constants in the host/CCPP framework.

Issue(s) addressed

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

  • ufs-wm Derecho regression tests
    • Regression Test Answer Changes
      • control_stochy_gnu failed only the bit-for-bit comparison
        • note: this test for intel, debug-intel, and debug-gnu passed
        • Some initial differences are tiny, around 1e-12, but the regression comparison has no numerical tolerance, so they fail
        • By hour 12, stochastic physics has amplified those perturbations into widespread differences
      • control_csawmg_gnu failed only the bit-for-bit comparison
        • note: this test for intel, debug-intel, and debug-gnu passed
        • The evidence points to the physical-constants refactor in UFSATM/ccpp/physics/physics/CONV/Chikira_Sugiyama/cs_conv.F90:303. Previously, derived quantities such as elocp, emeltocp, cpoel, and fact2 were compile-time parameters. They are now recomputed at runtime from CCPP arguments. Optimized GNU evaluates that arithmetic slightly differently
  • SCM regression tests will be completed soon

Related PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant