Skip to content

feat: Compatibility for Node 16#41

Merged
msciotti merged 3 commits intodiscord:masterfrom
hzmifork:feat/nodejs-v16
Oct 15, 2021
Merged

feat: Compatibility for Node 16#41
msciotti merged 3 commits intodiscord:masterfrom
hzmifork:feat/nodejs-v16

Conversation

@Hazmi35
Copy link
Copy Markdown
Contributor

@Hazmi35 Hazmi35 commented Aug 10, 2021 •
edited
Loading

Nodejs 16 uses V8 engine version 9.0, that requires c++14 features, so we need to remove "-std=c++11" from binding.gyp.
Idk why "-std=c++11" is added in f3c64a0

REFS:
nodejs/node-gyp#2387 (comment)
nodejs/node#38367

@Hazmi35
Copy link
Copy Markdown
Contributor Author

Hazmi35 commented Aug 10, 2021

Ah, my bad. I didn't see #40, should I close this PR?

@0xf0xx0
Copy link
Copy Markdown

0xf0xx0 commented Aug 12, 2021

I'll just merge with mines if I can

@0xf0xx0 0xf0xx0 mentioned this pull request Aug 12, 2021
Closed
@Hazmi35
Copy link
Copy Markdown
Contributor Author

Hazmi35 commented Aug 12, 2021

I'll just merge with mines if I can

Okay

@Hazmi35 Hazmi35 closed this Aug 12, 2021
@Hazmi35 Hazmi35 reopened this Aug 13, 2021
@Hazmi35
Copy link
Copy Markdown
Contributor Author

Hazmi35 commented Aug 13, 2021

Reopening this PR because #40 is closed

@promise promise mentioned this pull request Aug 14, 2021
Closed
@0xf0xx0 0xf0xx0 mentioned this pull request Aug 15, 2021
Closed
@Hazmi35
Copy link
Copy Markdown
Contributor Author

Hazmi35 commented Aug 15, 2021

I forgot to delete .node-version file. I used it for fnm to test with Node v16.

@jhgg
Copy link
Copy Markdown
Contributor

jhgg commented Aug 15, 2021

Can you delete the package lock?

@Hazmi35
Copy link
Copy Markdown
Contributor Author

Hazmi35 commented Aug 16, 2021 •
edited
Loading

Can you delete the package lock?

Hi sorry, for the late response, I just deleted the lockfile @jhgg

@fredkilbourn fredkilbourn mentioned this pull request Aug 16, 2021
Closed
@Zoddo
Copy link
Copy Markdown

Zoddo commented Aug 16, 2021

While you are at it, merging #42 would be useful too :)

@jhgg
Copy link
Copy Markdown
Contributor

jhgg commented Aug 16, 2021

@adill - when you get a chance, can you double check that this looks sensible?

@Hazmi35
Copy link
Copy Markdown
Contributor Author

Hazmi35 commented Aug 16, 2021 •
edited
Loading

Edited the first message for an explanation. Note that this has not been tested in Mac OS, but it works on Node.js v8 to v16 on Arch Linux, Node.js v8 to v16 on Windows (build 19044.1165, msvs 2019), and Node.js v14-v16 on Alpine Linux (docker)

@fredkilbourn
Copy link
Copy Markdown

fredkilbourn commented Aug 25, 2021

@jhgg @adill Hi guys, its been a week just bumping to see if you have a minute to review/merge this yet. Thanks!

@Milo123459
Copy link
Copy Markdown

Milo123459 commented Aug 27, 2021

Yea, eta would be good. Other pr is fucked.

@satoufuyuki
Copy link
Copy Markdown

satoufuyuki commented Aug 30, 2021

any progress?

@fredkilbourn
Copy link
Copy Markdown

fredkilbourn commented Sep 6, 2021

@jhgg @adill weekly bump, apologies

@Hazmi35
Copy link
Copy Markdown
Contributor Author

Hazmi35 commented Sep 23, 2021

Hi, sorry for the bump, any progress on PR Review? Just a friendly reminder that Node 16 will be an Active LTS next month.

@satoufuyuki satoufuyuki mentioned this pull request Sep 24, 2021
Merged
mzrtamp pushed a commit to stegripe/rawon that referenced this pull request Sep 24, 2021
chore(deps-opt): use hzmifork/erlpack
2981a3a 
Still no ETA until hzmi's fork merged, use hzmifork or don't add this [discord/erlpack#41](discord/erlpack#41)

Co-authored-by: Zen <45705890+KurokuTetsuya@users.noreply.github.com>
chakany added a commit to chakany/erlpack that referenced this pull request Sep 24, 2021
@chakany
support for node 16 (discord#41)
ee1dfde
@fredkilbourn
Copy link
Copy Markdown

fredkilbourn commented Sep 30, 2021

Sorry again, but bump

@n1ckoates n1ckoates mentioned this pull request Oct 1, 2021
Closed
@fredkilbourn
Copy link
Copy Markdown

fredkilbourn commented Oct 13, 2021

Another 2 weeks bump, is it possible to get this merged? @jhgg @adill

@msciotti
Copy link
Copy Markdown
Contributor

msciotti commented Oct 15, 2021

Got final signoff from Jake and Andy. Thanks for this!

@msciotti msciotti merged commit f7d730d into discord:master Oct 15, 2021
This was referenced Oct 15, 2021
Merged
Merged
@SuperchupuDev SuperchupuDev mentioned this pull request Oct 19, 2021
Closed
@GoldenAngel2 GoldenAngel2 mentioned this pull request Oct 23, 2021
Open
@Hazmi35 Hazmi35 deleted the feat/nodejs-v16 branch January 19, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Hazmi35 @0xf0xx0 @jhgg @Zoddo @fredkilbourn @Milo123459 @satoufuyuki @msciotti