Skip to content

feat: Compatibility for Node 16#44

Closed
icdevin wants to merge 1 commit intodiscord:masterfrom
icdevin:master
Closed

feat: Compatibility for Node 16#44
icdevin wants to merge 1 commit intodiscord:masterfrom
icdevin:master

Conversation

@icdevin
Copy link
Copy Markdown

@icdevin icdevin commented Aug 13, 2021

Originally from https://github.com/Hazmi35

@icdevin
Copy link
Copy Markdown
Author

icdevin commented Aug 13, 2021

@jhgg These are the original changes from the other 2 closed PRs.

@promise
Copy link
Copy Markdown

promise commented Aug 14, 2021

Reinstalling node-gyp should resolve compiling issues with node v16. Try npm uni -g node-gyp && npm i -g node-gyp.
Me myself, and a friend of mine, have gotten it working doing this although we're not entirely sure if it will work for everyone.

It also looks like this is a dupe of #41, or the other way around. (#41 was reopened half an hour after this PR was made)
Seeing as this PR originates from #41's author, I'd suggest closing this and instead having #41, but I'm not a maintainer so feel free to wait for a maintainer to give their input.

@wrac4242
Copy link
Copy Markdown

Reinstalling node-gyp should resolve compiling issues with node v16. Try npm uni -g node-gyp && npm i -g node-gyp.
Me myself, and a friend of mine, have gotten it working doing this although we're not entirely sure if it will work for everyone.

It also looks like this is a dupe of #41, or the other way around. (#41 was reopened half an hour after this PR was made)
Seeing as this PR originates from #41's author, I'd suggest closing this and instead having #41, but I'm not a maintainer so feel free to wait for a maintainer to give their input.

Hi, the given command does not work for me, I still get the same compiling error trying to reinstall erlpack
uname output Linux wrac-fedora 5.13.9-200.fc34.x86_64 #1 SMP x86_64 GNU/Linux

@icdevin
Copy link
Copy Markdown
Author

icdevin commented Aug 14, 2021

@promise Agreed. Since he reopened it, I’ll shut this.

@icdevin icdevin closed this Aug 14, 2021
@fredkilbourn
Copy link
Copy Markdown

That command didn't fix things for me, either.

@promise
Copy link
Copy Markdown

promise commented Aug 15, 2021

Apologies, probably me having issues then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants