Redo node 16 support#45
Closed
0xf0xx0 wants to merge 1 commit intodiscord:masterfrom
0xf0xx0:GingkathFox-patch-1
Closed
Redo node 16 support#450xf0xx0 wants to merge 1 commit intodiscord:masterfrom 0xf0xx0:GingkathFox-patch-1
0xf0xx0 wants to merge 1 commit intodiscord:masterfrom
0xf0xx0:GingkathFox-patch-1
Conversation
Author
|
Gonna update packages too, don’t merge yet (or merge then merge #41, which also updates the packages) |
Author
|
It seems pointless to have two PRs fixing the same issue, and if you're going to also update packages then this is pretty much a copy of #41. Merging both PRs will also have an unnecessary conflict as they have the same changes. Resolving the conflict and merging both PRs will only confuse and has the same effect as merging one and closing the other one. I would suggest closing this and keep #41 but feel free to wait for a maintainer to give their input instead. |
Contributor
|
Closing as dupe of #41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn’t move to a new branch in #40, fixed here without extraneous changes