Repository navigation
fix(ci): use static DMG filename without version suffix - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The release DMG was named with the version appended (e.g.
ForgeCode-0.1.3.dmg). This changes it to a simple, staticForgeCode.dmg.Changes
macos/scripts/common.sh—DMG_NAMEdefault is nowForgeCodeinstead ofForgeCode-$APP_VERSION. This single variable drivesDMG_PATH, staging temp file names, and the manifestdmg_namefield, so the rest of the packaging scripts follow automatically..github/workflows/release.ymlDMG_NAME=ForgeCode$suffix/dmg_file=ForgeCode$suffix.dmg. The-unsignedsuffix for PR dry runs is preserved.jqfilter matchesstartswith("ForgeCode")rather thanstartswith("ForgeCode-"), so previously-uploaded versioned assets are still matched and pruned.Notes
<enclosure url>is tag-scoped (releases/download/$TAG_NAME/$DMG_FILE), and the update version comes fromsparkle:shortVersionString/sparkle:version, not from the filename. A fixed filename per tag is safe.Info.plist, andmanifest.txt.Verification
sh scripts/test-packaging.shpasses all 18 checks, including "legacy fixed-name DMG staging residue is removed".