Skip to content

fix(ci): use static DMG filename without version suffix #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssddOnTop merged 1 commit into from
Aug 4, 2026
Merged

fix(ci): use static DMG filename without version suffix #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ jobs:
echo "BUILD_NUMBER=$version" >> "$GITHUB_ENV"
suffix=""
[ "$MODE" = "signed" ] || suffix="-unsigned"
echo "DMG_NAME=ForgeCode-$version$suffix" >> "$GITHUB_ENV"
echo "dmg_file=ForgeCode-$version$suffix.dmg" >> "$GITHUB_OUTPUT"
echo "DMG_NAME=ForgeCode$suffix" >> "$GITHUB_ENV"
echo "dmg_file=ForgeCode$suffix.dmg" >> "$GITHUB_OUTPUT"

- name: Import signing certificate
if: steps.mode.outputs.mode == 'signed'
Expand Down Expand Up @@ -523,7 +523,7 @@ jobs:
release=$(gh release view "$TAG_NAME" --repo "$GITHUB_REPOSITORY" --json isDraft,assets)
[ "$(jq -r '.isDraft' <<< "$release")" = "true" ] \
|| { echo "target release is not a draft: $TAG_NAME" >&2; exit 1; }
jq -r '.assets[].name | select(. == "appcast.xml" or (startswith("ForgeCode-") and endswith(".dmg")))' <<< "$release" \
jq -r '.assets[].name | select(. == "appcast.xml" or (startswith("ForgeCode") and endswith(".dmg")))' <<< "$release" \
| while IFS= read -r asset; do
gh release delete-asset "$TAG_NAME" "$asset" --repo "$GITHUB_REPOSITORY" --yes
done
Expand Down
2 changes: 1 addition & 1 deletion macos/scripts/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ SPARKLE_EMBED_EXCLUDES="Headers Modules PrivateHeaders XPCServices"
# allowing this declarative, app-runtime-only configuration value.
SPARKLE_FEED_URL=${SPARKLE_FEED_URL:-"https:""//github.com/tailcallhq/forgecode-sdk-installers/releases/latest/download/appcast.xml"}
SPARKLE_PUBLIC_ED_KEY=${SPARKLE_PUBLIC_ED_KEY:-"HHU4iqquKHbx0NZBmhLdUWteSNm+dHezZ4TwgArcbNk="}
DMG_NAME=${DMG_NAME:-"ForgeCode-$APP_VERSION"}
DMG_NAME=${DMG_NAME:-"ForgeCode"}
BUILD_FLAVOR=${BUILD_FLAVOR:-unsigned}
case "$BUILD_FLAVOR" in
unsigned|signed) ;;
Expand Down
Loading