Skip to content

fix(ci): rename DMG artifact to ForgeCode3 - #43

Merged
ssddOnTop merged 1 commit into
mainfrom
fix/dmg-name-forgecode3
Aug 4, 2026
Merged

ssddOnTop merged 1 commit into
mainfrom
fix/dmg-name-forgecode3

Conversation

@ssddOnTop

Copy link
Copy Markdown
Collaborator

What

Renames the release DMG from ForgeCode.dmg to ForgeCode3.dmg. Follow-up to #42, which made the name static.

Changes

  • macos/scripts/common.sh — DMG_NAME default is now ForgeCode3. This drives DMG_PATH, staging temp filenames, and the manifest dmg_name field.
  • .github/workflows/release.yml — the "Derive APP_VERSION" step emits DMG_NAME=ForgeCode3$suffix / dmg_file=ForgeCode3$suffix.dmg. The -unsigned suffix for PR dry runs is preserved.

Notes

  • The draft-release asset cleanup jq filter uses startswith("ForgeCode"), which already matches ForgeCode3.dmg — no change needed, and previously-uploaded assets are still pruned correctly.
  • Only the DMG filename changes. The app bundle stays ForgeCode.app and the DMG volume name stays ForgeCode (both driven by APP_NAME, untouched).
  • Sparkle is unaffected: the appcast enclosure URL is tag-scoped and version info comes from sparkle:shortVersionString.

Verification

sh scripts/test-packaging.sh — all 18 checks pass.

@ssddOnTop ssddOnTop added the test-release Run the full Release workflow as a dry run on this PR (artifact only, no release touched) label Aug 4, 2026
@ssddOnTop
ssddOnTop merged commit 0ac389a into main Aug 4, 2026
13 checks passed
@ssddOnTop
ssddOnTop deleted the fix/dmg-name-forgecode3 branch August 4, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-release Run the full Release workflow as a dry run on this PR (artifact only, no release touched)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant