Repository navigation
fix(ci): rename DMG artifact to ForgeCode3 - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the release DMG from
ForgeCode.dmgtoForgeCode3.dmg. Follow-up to #42, which made the name static.Changes
macos/scripts/common.sh—DMG_NAMEdefault is nowForgeCode3. This drivesDMG_PATH, staging temp filenames, and the manifestdmg_namefield..github/workflows/release.yml— the "Derive APP_VERSION" step emitsDMG_NAME=ForgeCode3$suffix/dmg_file=ForgeCode3$suffix.dmg. The-unsignedsuffix for PR dry runs is preserved.Notes
jqfilter usesstartswith("ForgeCode"), which already matchesForgeCode3.dmg— no change needed, and previously-uploaded assets are still pruned correctly.ForgeCode.appand the DMG volume name staysForgeCode(both driven byAPP_NAME, untouched).sparkle:shortVersionString.Verification
sh scripts/test-packaging.sh— all 18 checks pass.