Argument Parser 1.8.0 now does parsing async#1428
Closed
finagolfin wants to merge 2 commits into
Closed
Conversation
finagolfin
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
Member
Author
|
@swift-ci test |
owenv
approved these changes
May 26, 2026
Member
Author
|
@swift-ci test windows |
Contributor
|
@swift-ci test |
jakepetroules
approved these changes
May 26, 2026
Closed
Contributor
|
@swift-ci test |
Member
Author
|
The three required CI had already passed, no need to rerun them. The static linux SDK failures are unrelated. |
Contributor
Two of the three required jobs hadn't run which is why I had kicked it again |
Member
Author
|
Oh, you're right: they had run and passed, but the github test view wasn't registering the results correctly, rendering the passing runs useless. That is a common failure mode for the Windows CI in particular, ie the test run passes but GitHub can't see it. 🤦♂️ |
Member
Author
|
Closing since apple/swift-argument-parser#908 in the new 1.8.1 tag changed this back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had to patch this locally for the last couple months of using the main branch of Argument Parser, which we'll need merged now that the toolchain is being updated to use Argument Parser 1.8.0, swiftlang/swift#89404, with this change most likely tied to apple/swift-argument-parser#855.