fix: add missing await#1432
Closed
Brett-Best wants to merge 1 commit into
Closed
Conversation
Brett-Best
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
May 27, 2026 01:55
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates pbxcp to await asynchronous option parsing.
Changes:
- Switch
CopyOptions.parse(argv)call totry await CopyOptions.parse(argv)insidepbxcp.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Closing in favour of #1428 which I missed when looking through the list before making this 🥲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
I believe this was caused by apple/swift-argument-parser@d6f4e7a and the dependency constraint for it is
from: "1.0.3"meaning1.8.0satisfies this - hence it breaking.If a lower version is checked out now a warning of:
No 'async' operations occur within 'await' expressionis generated.I thought the below might work:
But I get: https://docs.swift.org/compiler/documentation/diagnostics/module-version-missing/
I thought I saw SwiftPM would set this but perhaps that hasn't shipped yet or I imagined it :D