Argument parsing is now async since apple/swift-argument-parser#855#10121
Closed
finagolfin wants to merge 2 commits into
Closed
Argument parsing is now async since apple/swift-argument-parser#855#10121finagolfin wants to merge 2 commits into
finagolfin wants to merge 2 commits into
Conversation
This is needed for swiftlang/swift#89404, which updates the Argument Parser used to the latest 1.8.0 tag.
finagolfin
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
finagolfin
commented
May 26, 2026
| } else if self.options._deprecated_shouldListTests { | ||
| // Backward compatibility 6/2022 for deprecation of a flag into a subcommand. | ||
| let command = try List.parse() | ||
| let command = try await List.parse() |
Member
Author
There was a problem hiding this comment.
Alternatively, we could finally throw out the long-deprecated list-tests subcommand.
Member
Author
|
@swift-ci test self hosted |
jakepetroules
approved these changes
May 26, 2026
Contributor
|
@swift-ci test |
Contributor
Contributor
|
swiftlang/swift-build#1428 @swift-ci test windows |
Member
Author
|
Closing since apple/swift-argument-parser#908 in the new 1.8.1 tag changed this back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for swiftlang/swift#89404, which updates the Argument Parser used to the latest 1.8.0 tag.
Depends on swiftlang/swift-build#1428
Blocks: swiftlang/swift#89404