Skip to content

Argument parsing is now async since apple/swift-argument-parser#855 #10121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
finagolfin wants to merge 2 commits into from
Closed

Argument parsing is now async since apple/swift-argument-parser#855 #10121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de7339b
Argument parsing is now async since apple/swift-argument-parser#855
finagolfin May 26, 2026
76c43a9
Update SAP in Package.swift to 1.8.0
bkhouri May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,7 @@ if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil {
// utils/update_checkout/update-checkout-config.json
// They are used to build the official swift toolchain.
.package(url: "https://github.com/swiftlang/swift-syntax.git", branch: relatedDependenciesBranch),
.package(url: "https://github.com/apple/swift-argument-parser.git", revision: "1.6.1"),
.package(url: "https://github.com/apple/swift-argument-parser.git", revision: "1.8.0"),
.package(url: "https://github.com/apple/swift-crypto.git", revision: "3.12.5"),
.package(url: "https://github.com/apple/swift-system.git", revision: "1.5.0"),
.package(url: "https://github.com/apple/swift-collections.git", revision: "1.1.6"),
Expand Down
2 changes: 1 addition & 1 deletion Sources/Commands/SwiftTestCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ public struct SwiftTestCommand: AsyncSwiftCommand {
try await printCodeCovPath(swiftCommandState)
} else if self.options._deprecated_shouldListTests {
// Backward compatibility 6/2022 for deprecation of a flag into a subcommand.
let command = try List.parse()
let command = try await List.parse()

@finagolfin finagolfin May 26, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could finally throw out the long-deprecated list-tests subcommand.

try await command.run(swiftCommandState)
} else {
let (productsBuildParameters, _) = try swiftCommandState.buildParametersForTest(options: self.options)
Expand Down
Loading