Skip to content

apollo_batcher: read state commitment infos from the committer on a cache miss - #15067

Open
yoavGrs wants to merge 1 commit into
graphite-base/15067from
commitment-infos-3-committer-fallback
Open

apollo_batcher: read state commitment infos from the committer on a cache miss#15067
yoavGrs wants to merge 1 commit into
graphite-base/15067from
commitment-infos-3-committer-fallback

Conversation

@yoavGrs

@yoavGrs yoavGrs commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

yoavGrs commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

@cursor

cursor Bot commented Aug 27, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Adds a committer dependency at batcher startup for cache warming; failures are non-fatal but may increase storage reads until commitments catch up.

Overview
On batcher start, the node now prefetches state commitment infos from the committer for recent heights already committed in storage (from storage_height - STORED_BLOCK_HASH_BUFFER up to the commitment task offset) and fills recent_state_commitment_infos_cache, so get_state_commitment_infos / has_state_commitment_infos can hit memory instead of storage for that window.

If the committer RPC fails, startup continues with an empty cache (warning only). Default test mocks stub get_state_commitment_infos; new tests assert the requested height range and tolerance for committer outages.

Reviewed by Cursor Bugbot for commit 1d4d2db. Bugbot is set up for automated code reviews on this repo. Configure here.

@yoavGrs
yoavGrs force-pushed the commitment-infos-2-batcher-cache branch from 098f1f3 to 8aad038 Compare August 27, 2026 14:56
@yoavGrs
yoavGrs force-pushed the commitment-infos-3-committer-fallback branch from e4e41ac to 381d66f Compare August 27, 2026 14:56
@yoavGrs
yoavGrs force-pushed the commitment-infos-2-batcher-cache branch from 8aad038 to b2dccee Compare August 30, 2026 11:15
@yoavGrs
yoavGrs force-pushed the commitment-infos-3-committer-fallback branch from 381d66f to ee9fd48 Compare August 30, 2026 11:15
@yoavGrs
yoavGrs force-pushed the commitment-infos-3-committer-fallback branch from ee9fd48 to b600bcf Compare August 30, 2026 11:20
@yoavGrs
yoavGrs force-pushed the commitment-infos-2-batcher-cache branch from b2dccee to 04d3215 Compare August 30, 2026 11:20
@yoavGrs
yoavGrs changed the base branch from commitment-infos-2-batcher-cache to graphite-base/15067 August 30, 2026 13:30
@yoavGrs
yoavGrs force-pushed the commitment-infos-3-committer-fallback branch from b600bcf to 1d4d2db Compare August 30, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants