apollo_batcher: cache recent state commitment infos in memory

[yoavGrs]

No description provided.

[reviewable-StarkWare]

This change is 

[yoavGrs]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_storage: drop the legacy state commitment infos table and file at startup #15075
• apollo_storage,apollo_batcher,apollo_reverts: remove state commitment infos from storage #15068
• apollo_batcher: read state commitment infos from the committer on a cache miss #15067
• apollo_batcher: evict the reverted height from the caches after writing the pending results #15076
• apollo_batcher: cache recent state commitment infos in memory #15066 👈 (View in Graphite)
• apollo_committer,apollo_committer_types: add an API for reading state commitment infos #15065
• main-v0.14.4

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Read-path caching and revert cleanup mirror the established block-hash cache; no new persistence or external API semantics beyond faster reads for recent blocks.

Overview
Adds an in-memory LRU cache (20 blocks) for compressed state commitment infos, parallel to the existing recent block-hash cache.

Commitment manager: Populates the cache when commitment results are written to storage; removes the entry for a block when a revert completes.

Batcher API: get_state_commitment_infos and has_state_commitment_infos now take &mut self, drain pending commitment results first (same as get_block_hash), then return from the cache when present before falling back to storage.

Tests cover cache hits after ReadPathsAndCommitBlock, and that revert clears the cache.

^{Reviewed by Cursor Bugbot for commit 04d3215. Bugbot is set up for automated code reviews on this repo. Configure here.}

[itamar-starkware]

@itamar-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on yoavGrs).

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b2dccee. Configure here.}

[cursor]

Stale cache after block revert

Medium Severity

wait_for_revert_result pops the reverted height from recent_state_commitment_infos_cache, but write_commitment_results_to_storage then caches any still-pending commit for that same height. get_state_commitment_infos and has_state_commitment_infos then return that entry after storage has already dropped it.

Additional Locations (2)

• crates/apollo_batcher/src/commitment_manager/commitment_manager_impl.rs#L242-L243
• crates/apollo_batcher/src/batcher.rs#L1628-L1646

 

^{Reviewed by Cursor Bugbot for commit b2dccee. Configure here.}

[yoavGrs]

@yoavGrs made 1 comment.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on itamar-starkware).