Rollup of 4 pull requests#156111
Merged
rust-bors[bot] merged 18 commits intorust-lang:mainfrom May 3, 2026
Merged
Conversation
splits the large triple suggestion into three sets them to MaybeIncorrect automatically determines the required/nicest borrowing to use.
…7 instead of E0594 a set of slightly different tests showing that E0594 can be reached in some cases via autodereferencing, but also that slight variations produce E0277 instead.
added a valid example that violated the assumption in the proposed change: it is possible for a borrowee type to be a ref of it's borrowed type. removed the assumption, treated all cases appropriately.
…r printing MaybeUninit The derived implementation requires `T: Debug`, and doesn't need to.
…r=Urgau [rustdoc] Fix `doc_cfg` feature on reexports Part of rust-lang#150268. I don't mark the issue as fixed as I need to check the third case described in the issue. First commit comes from rust-lang#156020, will need to rebase this PR once the original is merged. r? @Urgau
…nathanBrouwer Fix 'assign to data in an index of' collection suggestions fixes rust-lang#150001 fixes rust-lang/rust-analyzer#16076 fixes rust-lang#134917 The issues are threefold and linked: 1. Assigning data to a ~~collection~~BTreeMap/HashMap suggests 3 solutions all marked as `MachineApplicable` 2. The suggestions are slightly wrong with regards to their borrowing needs. 3. The suggestions are not guaranteed to produce code that is valid, and suggestion number two is equivalent to an update, not an insertion. This PR: - splits the large triple suggestion into three - sets them to `MaybeIncorrect` - automatically determines the required borrowing to use. I think this solution may not be very elegant, expecially the key typechecking / borrowing part, but it works. I am however very open to any improvement/change :) edit: edited to replace 'collection' with BTreeMap/HashMap'
…RalfJung,ShoyuVanilla Rip out rustc_layout_scalar_valid_range_* attribute support And either removes tests for it or replaces the uses with pattern types. primarily fixes rust-lang#135996 fixes rust-lang#147761 fixes rust-lang#133652
…uillaumeGomez Hand-implement `impl Debug for NumBuffer` to avoid constraining `T` or printing MaybeUninit The derived implementation requires `T: Debug`, and doesn't need to.
rustbot
added
A-attributes
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
merged-by-bors
Contributor
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 54f67d248b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 54f67d2 (parent) -> 818811b (this PR) Test differencesShow 47 test diffsStage 1
Stage 2
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 818811b3cd1e0ff0d8ef20d5a4cf0b7c079929bc --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced May 3, 2026
Collaborator
|
Finished benchmarking commit (818811b): comparison URL. Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILEDOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression ❗ ❗ ❗ ❗ ❗
❗ ❗ ❗ ❗ ❗ cc @rust-lang/wg-compiler-performance Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 494.817s -> 493.646s (-0.24%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
doc_cfgfeature on reexports #156073 ([rustdoc] Fixdoc_cfgfeature on reexports)impl Debug for NumBufferto avoid constrainingTor printing MaybeUninit #156098 (Hand-implementimpl Debug for NumBufferto avoid constrainingTor printing MaybeUninit)r? @ghost
Create a similar rollup