Implement borrowck for &pin mut|const $place#153693
Draft
frank-king wants to merge 7 commits intorust-lang:mainfrom
Draft
Implement borrowck for &pin mut|const $place#153693frank-king wants to merge 7 commits intorust-lang:mainfrom
&pin mut|const $place#153693frank-king wants to merge 7 commits intorust-lang:mainfrom
Conversation
4 tasks
This comment has been minimized.
This comment has been minimized.
f6b714b to
46c66aa
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
63fbcd8 to
122d1be
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
I think about whether to allow the |
Remove the now-unnecessary helper method and access state.pinned_borrows directly.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Let me self-review the whole PR carefully before marking it ready for review. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
P8L1
suggested changes
May 3, 2026
| } | ||
|
|
||
| #[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord, TyEncodable, TyDecodable)] | ||
| #[derive(Hash, HashStable)] |
There was a problem hiding this comment.
I think they renamed it, should it not be 'StableHash' instead of 'HashStable'?
Refer to: e7d28d3
I made a PR to fix it: frank-king#7
Contributor
|
☔ The latest upstream changes (presumably #156111) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Pin Ergonomics.
This forbids places to be moved or mutably borrowed ever since they are pinned until they are reassigned (even after the pinned borrows themselves expire).
Tasks:
Pinsdataflow analysispinpattern matching&pinborrows for ADTs without#[pin_v2](for soundness concerns)Unresolved questions
&pinborrows to be applied to generic ADTs without#[pin_v2]? (related discussions: Require #[pin_v2] for direct &pin borrows of ADTs frank-king/rust#2 (comment))&pinborrowed places ofUnpintypes be prevented from being moved, or just don't treatUnpintypes specially and emit move-after-pin as usual?