Stabilize int_format_into feature#152544
Open
GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
Open
Stabilize int_format_into feature#152544GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
int_format_into feature#152544GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
Conversation
GuillaumeGomez
added
the
T-libs-api
Collaborator
|
Some changes occurred in integer formatting cc @tgross35 |
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
added
needs-fcp
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
stabilize-int_format_into
branch
from
84973ef to
03a0f20
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
stabilize-int_format_into
branch
from
03a0f20 to
897eb89
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
stabilize-int_format_into
branch
from
897eb89 to
2ec6387
Compare
This comment has been minimized.
This comment has been minimized.
4 tasks
Amanieu
reviewed
Mar 28, 2026
GuillaumeGomez
force-pushed
the
stabilize-int_format_into
branch
from
2ec6387 to
74ce864
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
GuillaumeGomez
force-pushed
the
stabilize-int_format_into
branch
from
74ce864 to
28edb57
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
stabilize-int_format_into
branch
from
28edb57 to
f93c2e2
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
stabilize-int_format_into
branch
from
f93c2e2 to
ec80536
Compare
GuillaumeGomez
commented
Mar 28, 2026
| /// Returns the length of the internal buffer. | ||
| #[unstable(feature = "int_format_into", issue = "138215")] | ||
| pub const fn capacity(&self) -> usize { | ||
| pub(crate) const fn capacity(&self) -> usize { |
Member
Author
There was a problem hiding this comment.
Because the size of NumBuffer is always the same, we are forced to use this method until we can actually use the NumBufferTrat::BUF_SIZE when declaring NumBuffer.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
stabilize-int_format_into
branch
from
ec80536 to
789f4f2
Compare
Member
Author
|
Finally fixed CI. ^^' |
Contributor
|
☔ The latest upstream changes (presumably #156111) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138215.
r? @Amanieu