Skip to content

test(cli): give the closed-pipe check a report too big to land early #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nolindnaidoo merged 1 commit into from
Oct 17, 2026
Merged

test(cli): give the closed-pipe check a report too big to land early #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions scripts/check-cli-pipes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
*
* Shared by every repo with an npm command line, and held identical by
* letools-site's fleet check. `--mcp-only` skips the command-line cases,
* for a tool whose command line needs the network.
* for a tool whose command line cannot read the shared tree: one that needs
* the network, or one that reads a set of catalogues rather than files.
*
* Run: bun run build:cli && cargo build --locked --manifest-path crate/Cargo.toml
* bun scripts/check-cli-pipes.ts [--mcp-only]
Expand Down Expand Up @@ -56,13 +57,22 @@ function file(name: string, content: string): void {
writeFileSync(join(tree, name), content);
created.push(join(tree, name));
}
// Something every extractor finds, many times over, and two dotenv files
// that disagree on every key.
// Something every extractor finds, many times over, two dotenv files that
// disagree on every key, and two manifests that disagree on every
// dependency. A report too small to outlast the pipe's buffer can land
// before the close does, and then the case proves nothing.
const line = '#ff0000 /usr/local/bin/tool "a string" 12345 https://a.example/x KEY=value\n';
const manifest = (version: string) =>
JSON.stringify({
dependencies: Object.fromEntries(Array.from({ length: 5_000 }, (_, at) => [`dep-${at}`, version])),
});
mkdirSync(join(tree, 'big'));
mkdirSync(join(tree, 'big', 'other'));
file('big/many.txt', line.repeat(20_000));
file('big/.env.example', Array.from({ length: 20_000 }, (_, at) => `KEY_${at}=v`).join('\n'));
file('big/.env', 'OTHER=1\n');
file('big/package.json', manifest('1'));
file('big/other/package.json', manifest('2'));

const list = (id: number) => JSON.stringify({ jsonrpc: '2.0', id, method: 'tools/list' });
const requests = `${Array.from({ length: 300 }, (_, at) => list(at)).join('\n')}\n`;
Expand Down Expand Up @@ -97,6 +107,7 @@ try {
}
} finally {
for (const path of created) unlinkSync(path);
rmdirSync(join(tree, 'big', 'other'));
rmdirSync(join(tree, 'big'));
rmdirSync(tree);
}
Expand Down
Loading