Repository navigation
test(cli): give the closed-pipe check a report too big to land early - #61
Merged
Merged
Conversation
The shared tree had no manifests, so versions-le wrote one short line, and on macOS CI the Rust binary wrote it before the harness closed the pipe. The case then proved nothing and the check failed. Two manifests that disagree on 5,000 dependencies give every tool a report that outlasts the buffer. The --mcp-only comment now names both reasons a tool skips the command-line cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-cli-pipes.tstree gains two manifests that disagree on 5,000 dependencies. versions-le's report used to be one short line, which the Rust binary could write before the pipe closed, so the macOS case proved nothing and failed.--mcp-onlycomment now covers i18n-le's reason as well as the network one.