feat: Benchmark wallets on `deposit-addresses` best practice, batch 3 by Y3drk · Pull Request #247 · namehash/ensawards

Y3drk · 2026-06-23T15:20:34Z

Lite PR → Benchmark wallets on `deposit-addresses` best practice, batch 2

Summary

Benchmarks apps of type wallet on deposit-addresses best practice.
Added in this PR:
- Frame
- Kraken wallet

Why

These wallets were not benchmarked yet on the new best practice

Testing

Ran typecheck, lint, and test commands locally to ensure that the migration didn't break anything, and later confirmed that in our CI workflow
Verified that the UI didn't break after introducing changes using a local and Vercel previews.

Pre-Review Checklist (Blocking)

This PR does not introduce significant changes and is low-risk to review quickly.

vercel · 2026-06-23T15:20:40Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
ensawards.org	Ready	Preview, Comment	Jun 23, 2026 3:24pm

coderabbitai · 2026-06-23T15:21:07Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8e39caae-fd5f-4585-8b7f-98c9b8ae70cc

📥 Commits

Reviewing files that changed from the base of the PR and between e46622e and e1020cb.

⛔ Files ignored due to path filters (12)

ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-addresses/at-1.png is excluded by !**/*.png
ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-addresses/at-2.png is excluded by !**/*.png
ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-addresses/at-3.png is excluded by !**/*.png
ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-addresses/at-4.png is excluded by !**/*.png
ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-addresses/at-5.png is excluded by !**/*.png
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/at-1.png is excluded by !**/*.png
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/at-2.png is excluded by !**/*.png
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/at-3.png is excluded by !**/*.png
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/at-4.png is excluded by !**/*.png
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/at-5.png is excluded by !**/*.png
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/at-6.png is excluded by !**/*.png
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/at-7.png is excluded by !**/*.png

📒 Files selected for processing (6)

ensawards.org/data/apps/frame-wallet/benchmarks/index.tsx
ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-address/index.tsx
ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-addresses/index.tsx
ensawards.org/data/apps/kraken-wallet/benchmarks/index.tsx
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-address/index.tsx
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/index.tsx

💤 Files with no reviewable changes (2)

ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-address/index.tsx
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-address/index.tsx

📝 Walkthrough

Walkthrough

Replaces empty stub benchmark modules (resolution/deposit-address) for Frame Wallet and Kraken Wallet with fully populated resolution/deposit-addresses modules containing AT01–AT08 benchmark entries, contributor attribution, proof images, and pass/fail notes. Each app's benchmark registry import is updated to the new plural path.

Changes

Deposit-addresses benchmark modules (Frame & Kraken Wallet)

Layer / File(s)	Summary
New deposit-addresses benchmark definitions `ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-addresses/index.tsx`, `ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/index.tsx`	Adds fully populated `depositAddresses` constants (AT01–AT08) for both wallets, each with `BenchmarkResults`, contributor records using `parseTimestamp`, pass/fail/not-applicable note builders with proof images and extra failure strings, exported as `AcceptanceTestBenchmarks`-typed defaults. Removes the old stub `deposit-address/index.tsx` files from both apps.
Benchmark registry import rewiring `ensawards.org/data/apps/frame-wallet/benchmarks/index.tsx`, `ensawards.org/data/apps/kraken-wallet/benchmarks/index.tsx`	Updates the `depositAddresses` import path in each app's benchmark registry from `./resolution/deposit-address` (singular) to `./resolution/deposit-addresses` (plural).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

namehash/ensawards#233: Introduces the deposit-address best-practice benchmarks that this PR populates for Frame and Kraken Wallet.
namehash/ensawards#235: Applies the same deposit-address → deposit-addresses module rename and benchmark population pattern.
namehash/ensawards#244: Part of the same broader rollout switching app benchmark registries from resolution/deposit-address to resolution/deposit-addresses.

Poem

🐇 A folder once singular, now takes the plural stage,
AT01 through AT08 fill every benchmark page,
Pass notes with proof images, fail notes with extra strings,
parseTimestamp ticking for each contributor it brings,
Frame and Kraken wallets, your addresses now shine —
This rabbit hops with joy at every satisfies line! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding benchmarks for wallet applications on the deposit-addresses best practice. However, it says 'batch 3' while the description mentions 'batch 2', creating a minor discrepancy.
Description check	✅ Passed	The description is directly related to the changeset, detailing the addition of benchmarks for Frame and Kraken wallet on the deposit-addresses best practice, with testing and verification details provided.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch y3drk/feat/add-benchmarks-for-wallets-on-da-bp-tranche3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…bp-tranche3

Copilot

Pull request overview

This PR benchmarks two wallet apps (Frame Wallet and Kraken Wallet) against the deposit-addresses ENS resolution best practice by adding full acceptance-test result data (with proof assets) and wiring the apps’ benchmark registries to the new deposit-addresses benchmark modules.

Changes:

Added complete deposit-addresses acceptance-test benchmark results for Frame Wallet and Kraken Wallet (including proof images and standardized notes).
Updated each app’s benchmarks registry to import/use ./resolution/deposit-addresses.
Removed the previous placeholder deposit-address benchmark stubs for these apps.

Reviewed changes

Copilot reviewed 6 out of 18 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/index.tsx	Adds Kraken Wallet `deposit-addresses` benchmark results (AT1–AT8) with proof references and notes.
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-address/index.tsx	Removes the old placeholder stub benchmark module.
ensawards.org/data/apps/kraken-wallet/benchmarks/index.tsx	Switches registry import to `./resolution/deposit-addresses` and maps it to `"deposit-addresses"`.
ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-addresses/index.tsx	Adds Frame Wallet `deposit-addresses` benchmark results (AT1–AT8) with proof references and notes.
ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-address/index.tsx	Removes the old placeholder stub benchmark module.
ensawards.org/data/apps/frame-wallet/benchmarks/index.tsx	Switches registry import to `./resolution/deposit-addresses` and maps it to `"deposit-addresses"`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

greptile-apps · 2026-06-23T15:26:22Z

Greptile Summary

This PR fills in real benchmark results for Frame Wallet and Kraken Wallet on the deposit-addresses best practice, replacing the previous stub files (all undefined) with fully populated acceptance-test entries backed by proof screenshots.

Frame Wallet: passes AT1–AT3, fails AT4 (DNS name) and AT5 (Base chain address), marks AT6/AT7 NotApplicable (EVM-only wallet), and marks AT8 NotApplicable because AT5 failed.
Kraken Wallet: passes AT1–AT2, fails AT3–AT7 (offchain, DNS, Base chain, Bitcoin, Solana), and marks AT8 NotApplicable because AT5 failed.

Confidence Score: 5/5

Safe to merge — all changes are additive benchmark data files that replace stubs with real results; no shared logic was modified.

The only touched logic files are two benchmarks/index.tsx files that update an import path from deposit-address to deposit-addresses, matching the renamed directory. All remaining changes are new .tsx data files and image assets that follow the established pattern used by 27 other apps already in the repo. The as const satisfies AcceptanceTestBenchmarks constraint will catch any structural mismatches at compile time.

No files require special attention. The PR description heading says 'batch 2' while the PR title says 'batch 3' — a cosmetic mismatch worth correcting but with no code impact.

Important Files Changed

Filename	Overview
ensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-addresses/index.tsx	New deposit-addresses benchmark for Frame Wallet; replaces stub with full AT1–AT8 entries using shared note builders and proof images, following established patterns.
ensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-addresses/index.tsx	New deposit-addresses benchmark for Kraken Wallet; replaces stub with full AT1–AT8 entries; AT6/AT7 are Fail (multi-chain wallet that failed resolution) rather than NotApplicable.
ensawards.org/data/apps/frame-wallet/benchmarks/index.tsx	Import path updated from deposit-address to deposit-addresses to match the renamed directory.
ensawards.org/data/apps/kraken-wallet/benchmarks/index.tsx	Import path updated from deposit-address to deposit-addresses to match the renamed directory.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Frame Wallet ["Frame Wallet - deposit-addresses"]
        FA1["AT1: onchain name ✅ Pass"]
        FA2["AT2: normalization ✅ Pass"]
        FA3["AT3: offchain .eth subname ✅ Pass"]
        FA4["AT4: offchain DNS name ❌ Fail"]
        FA5["AT5: other EVM chain (Base) ❌ Fail"]
        FA6["AT6: Bitcoin address ⬜ N/A (EVM-only)"]
        FA7["AT7: Solana address ⬜ N/A (EVM-only)"]
        FA8["AT8: invalid address format ⬜ N/A (AT5 failed)"]
        FA5 --> FA8
    end

    subgraph Kraken Wallet ["Kraken Wallet - deposit-addresses"]
        KA1["AT1: onchain name ✅ Pass"]
        KA2["AT2: normalization ✅ Pass"]
        KA3["AT3: offchain .eth subname ❌ Fail"]
        KA4["AT4: offchain DNS name ❌ Fail"]
        KA5["AT5: other EVM chain (Base) ❌ Fail"]
        KA6["AT6: Bitcoin address ❌ Fail"]
        KA7["AT7: Solana address ❌ Fail"]
        KA8["AT8: invalid address format ⬜ N/A (AT5 failed)"]
        KA5 --> KA8
    end

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    subgraph Frame Wallet ["Frame Wallet - deposit-addresses"]
        FA1["AT1: onchain name ✅ Pass"]
        FA2["AT2: normalization ✅ Pass"]
        FA3["AT3: offchain .eth subname ✅ Pass"]
        FA4["AT4: offchain DNS name ❌ Fail"]
        FA5["AT5: other EVM chain (Base) ❌ Fail"]
        FA6["AT6: Bitcoin address ⬜ N/A (EVM-only)"]
        FA7["AT7: Solana address ⬜ N/A (EVM-only)"]
        FA8["AT8: invalid address format ⬜ N/A (AT5 failed)"]
        FA5 --> FA8
    end

    subgraph Kraken Wallet ["Kraken Wallet - deposit-addresses"]
        KA1["AT1: onchain name ✅ Pass"]
        KA2["AT2: normalization ✅ Pass"]
        KA3["AT3: offchain .eth subname ❌ Fail"]
        KA4["AT4: offchain DNS name ❌ Fail"]
        KA5["AT5: other EVM chain (Base) ❌ Fail"]
        KA6["AT6: Bitcoin address ❌ Fail"]
        KA7["AT7: Solana address ❌ Fail"]
        KA8["AT8: invalid address format ⬜ N/A (AT5 failed)"]
        KA5 --> KA8
    end

_{Reviews (1): Last reviewed commit: "Merge branch 'main' into y3drk/feat/add-..." | Re-trigger Greptile}

tk-o

LGTM

Add benchmarks for kraken wallet & frame

e1020cb

Y3drk self-assigned this Jun 23, 2026

Y3drk requested a review from a team as a code owner June 23, 2026 15:20

Copilot AI review requested due to automatic review settings June 23, 2026 15:20

Y3drk added the ensawards ENSAwards related label Jun 23, 2026

Copilot started reviewing on behalf of Y3drk June 23, 2026 15:21 View session

Merge branch 'main' into y3drk/feat/add-benchmarks-for-wallets-on-da-…

bce6464

…bp-tranche3

Copilot AI reviewed Jun 23, 2026

View reviewed changes

vercel Bot deployed to Preview June 23, 2026 15:24 View deployment

tk-o approved these changes Jun 23, 2026

View reviewed changes

Y3drk merged commit e9c7e3e into main Jun 23, 2026
11 checks passed

Y3drk deleted the y3drk/feat/add-benchmarks-for-wallets-on-da-bp-tranche3 branch June 23, 2026 15:38

This was referenced Jul 2, 2026

Track and retry pending benchmarks #252

Open

feat: add KuCoin exchange app, project, and resolution benchmarks #254

Merged

Navigation Menu

Uh oh!

feat: Benchmark wallets on `deposit-addresses` best practice, batch 3 - #247

feat: Benchmark wallets on `deposit-addresses` best practice, batch 3#247
Y3drk merged 2 commits into
mainfrom
y3drk/feat/add-benchmarks-for-wallets-on-da-bp-tranche3

Y3drk commented Jun 23, 2026

Uh oh!

vercel Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

greptile-apps Bot commented Jun 23, 2026

Uh oh!

tk-o left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Y3drk commented Jun 23, 2026

Lite PR → Benchmark wallets on deposit-addresses best practice, batch 2

Summary

Why

Testing

Pre-Review Checklist (Blocking)

Uh oh!

vercel Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

greptile-apps Bot commented Jun 23, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

tk-o left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lite PR → Benchmark wallets on `deposit-addresses` best practice, batch 2

vercel Bot commented Jun 23, 2026 •

edited

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading