This repository was archived by the owner on Aug 5, 2026. It is now read-only.
feat: add KuCoin exchange app, project, and resolution benchmarks - #254
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
👮 Files not reviewed due to content moderation or server errors (5)
📝 Walkthrough🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdds KuCoin as a new exchange app and project, with deposit-addresses and ensv2-ready-resolution benchmarks. The exchange does not support ENS names, so AT1 is
Confidence Score: 5/5Additive-only change: new app/project registration and benchmark data files with no modifications to shared infrastructure. All changed files follow the established patterns for exchange apps without ENS support. The contributor entry, ProjectIds addition, icon files, and benchmark results are consistent with comparable entries (WEEX, BingX). No shared logic is modified. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[kucoin-exchange/index.ts] -->|registers| B[KuCoinExchange App]
C[projects/kucoin/index.ts] -->|registers| D[KuCoinProject]
B -->|references| D
E[benchmarks/index.tsx] -->|defineAppBenchmarks| B
E --> F[deposit-addresses/index.tsx]
E --> G[ensv2-ready-resolution/index.tsx]
F --> F1[AT1: Fail - buildEnsNotSupportedNote]
F --> F2[AT2-AT8: NotApplicable - buildNotApplicableForFailedTest]
G --> G1[correctly-resolve-ensv2-test-name-address: NotApplicable]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[kucoin-exchange/index.ts] -->|registers| B[KuCoinExchange App]
C[projects/kucoin/index.ts] -->|registers| D[KuCoinProject]
B -->|references| D
E[benchmarks/index.tsx] -->|defineAppBenchmarks| B
E --> F[deposit-addresses/index.tsx]
E --> G[ensv2-ready-resolution/index.tsx]
F --> F1[AT1: Fail - buildEnsNotSupportedNote]
F --> F2[AT2-AT8: NotApplicable - buildNotApplicableForFailedTest]
G --> G1[correctly-resolve-ensv2-test-name-address: NotApplicable]
Reviews (3): Last reviewed commit: "Apply 07/02/26 GitHub review feedback" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Adds KuCoin as a first-class entity in the ENS Awards dataset by registering a new project, a new exchange app, and wiring in KuCoin-specific resolution benchmarks so it appears in the app/project registries and benchmark aggregation.
Changes:
- Add
ProjectIds.KuCoinand register a newKuCoinproject (with icon + socials). - Register a new
kucoin-exchangeapp (with icon + socials) linked to the KuCoin project. - Add and wire
deposit-addressesandensv2-ready-resolutionbenchmarks for the KuCoin exchange app.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ensawards.org/data/projects/types.ts | Adds a new ProjectIds.KuCoin identifier for project registry consistency. |
| ensawards.org/data/projects/kucoin/index.ts | Defines and registers the KuCoin project metadata. |
| ensawards.org/data/projects/kucoin/icon.tsx | Adds the KuCoin project SVG icon component. |
| ensawards.org/data/apps/kucoin-exchange/index.ts | Defines and registers the KuCoin exchange app linked to the KuCoin project. |
| ensawards.org/data/apps/kucoin-exchange/icon.tsx | Adds the KuCoin exchange app SVG icon component. |
| ensawards.org/data/apps/kucoin-exchange/benchmarks/index.tsx | Wires KuCoin exchange benchmarks into the benchmark registry. |
| ensawards.org/data/apps/kucoin-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx | Adds KuCoin’s ENSv2-ready-resolution benchmark outcome + proof. |
| ensawards.org/data/apps/kucoin-exchange/benchmarks/resolution/deposit-addresses/index.tsx | Adds KuCoin’s deposit-addresses benchmark outcomes using shared note builders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Resolved. I merged |
Y3drk
suggested changes
Jul 2, 2026
Y3drk
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark outcomes
deposit-addressesAT1:FailusingbuildEnsNotSupportedNote(withdraw flow on kucoin.com)AT2–AT8:NotApplicableviabuildNotApplicableForFailedTest({ testNumber: 1 })ensv2-ready-resolutionNotApplicablewith note explaining no ENS supportur.integration-tests.ethbeing rejectedWhy
Testing
Pre-Review Checklist (Blocking)