This repository was archived by the owner on Aug 5, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add KuCoin exchange app, project, and resolution benchmarks #254
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
18 changes: 18 additions & 0 deletions
18
ensawards.org/data/apps/kucoin-exchange/benchmarks/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md | ||
| // for additional advice on adding and modifying app benchmarks | ||
|
|
||
| import KuCoinExchange from "data/apps/kucoin-exchange"; | ||
| import { defineAppBenchmarks } from "data/benchmarks/registry"; | ||
| import type { BestPracticeBenchmarks } from "data/ens-best-practices/types"; | ||
|
|
||
| import depositAddresses from "./resolution/deposit-addresses"; | ||
| import ensv2ReadyResolution from "./resolution/ensv2-ready-resolution"; | ||
|
|
||
| const benchmarks: BestPracticeBenchmarks = { | ||
| "ensv2-ready-resolution": ensv2ReadyResolution, | ||
| "deposit-addresses": depositAddresses, | ||
| }; | ||
|
|
||
| defineAppBenchmarks(KuCoinExchange, benchmarks); | ||
|
|
||
| export default benchmarks; |
Binary file added
BIN
+109 KB
....org/data/apps/kucoin-exchange/benchmarks/resolution/deposit-addresses/at-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
104 changes: 104 additions & 0 deletions
104
ensawards.org/data/apps/kucoin-exchange/benchmarks/resolution/deposit-addresses/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| import type { AcceptanceTestBenchmarks } from "data/benchmarks/types"; | ||
| import { BenchmarkResults } from "data/benchmarks/types"; | ||
| import contributors from "data/contributors"; | ||
| import { | ||
| buildEnsNotSupportedNote, | ||
| buildNotApplicableForFailedTest, | ||
| } from "data/ens-best-practices/resolution/deposit-addresses/notes"; | ||
|
|
||
| import { parseTimestamp } from "@ensnode/ensnode-sdk"; | ||
|
|
||
| import at1Proof from "./at-1.png"; | ||
|
|
||
| const method = "the 'withdraw' feature on kucoin.com"; | ||
|
Y3drk marked this conversation as resolved.
Outdated
|
||
|
|
||
| const depositAddresses = { | ||
| "at01-resolve-onchain-name": { | ||
| result: BenchmarkResults.Fail, | ||
| contributions: [ | ||
| { | ||
| from: contributors.y3drk, | ||
|
Y3drk marked this conversation as resolved.
Outdated
|
||
| lastUpdated: parseTimestamp("2026-07-02T00:00:00Z"), | ||
|
Y3drk marked this conversation as resolved.
Outdated
|
||
| }, | ||
| ], | ||
| notes: buildEnsNotSupportedNote({ | ||
| method, | ||
| proof: { | ||
| image: at1Proof, | ||
| alt: "KuCoin doesn't accept ENS names as withdrawal addresses", | ||
| }, | ||
| }), | ||
| }, | ||
| "at02-resolve-name-needing-normalization": { | ||
| result: BenchmarkResults.NotApplicable, | ||
| contributions: [ | ||
| { | ||
| from: contributors.y3drk, | ||
| lastUpdated: parseTimestamp("2026-07-02T00:00:00Z"), | ||
| }, | ||
| ], | ||
| notes: buildNotApplicableForFailedTest({ testNumber: 1 }), | ||
| }, | ||
| "at03-resolve-offchain-eth-subname": { | ||
| result: BenchmarkResults.NotApplicable, | ||
| contributions: [ | ||
| { | ||
| from: contributors.y3drk, | ||
| lastUpdated: parseTimestamp("2026-07-02T00:00:00Z"), | ||
| }, | ||
| ], | ||
| notes: buildNotApplicableForFailedTest({ testNumber: 1 }), | ||
| }, | ||
| "at04-resolve-offchain-dns-name": { | ||
| result: BenchmarkResults.NotApplicable, | ||
| contributions: [ | ||
| { | ||
| from: contributors.y3drk, | ||
| lastUpdated: parseTimestamp("2026-07-02T00:00:00Z"), | ||
| }, | ||
| ], | ||
| notes: buildNotApplicableForFailedTest({ testNumber: 1 }), | ||
| }, | ||
| "at05-resolve-name-on-other-evm-chain": { | ||
| result: BenchmarkResults.NotApplicable, | ||
| contributions: [ | ||
| { | ||
| from: contributors.y3drk, | ||
| lastUpdated: parseTimestamp("2026-07-02T00:00:00Z"), | ||
| }, | ||
| ], | ||
| notes: buildNotApplicableForFailedTest({ testNumber: 1 }), | ||
| }, | ||
| "at06-resolve-bitcoin-address": { | ||
| result: BenchmarkResults.NotApplicable, | ||
| contributions: [ | ||
| { | ||
| from: contributors.y3drk, | ||
| lastUpdated: parseTimestamp("2026-07-02T00:00:00Z"), | ||
| }, | ||
| ], | ||
| notes: buildNotApplicableForFailedTest({ testNumber: 1 }), | ||
| }, | ||
| "at07-resolve-solana-address": { | ||
| result: BenchmarkResults.NotApplicable, | ||
| contributions: [ | ||
| { | ||
| from: contributors.y3drk, | ||
| lastUpdated: parseTimestamp("2026-07-02T00:00:00Z"), | ||
| }, | ||
| ], | ||
| notes: buildNotApplicableForFailedTest({ testNumber: 1 }), | ||
| }, | ||
| "at08-handle-invalid-address-format": { | ||
| result: BenchmarkResults.NotApplicable, | ||
| contributions: [ | ||
| { | ||
| from: contributors.y3drk, | ||
| lastUpdated: parseTimestamp("2026-07-02T00:00:00Z"), | ||
| }, | ||
| ], | ||
| notes: buildNotApplicableForFailedTest({ testNumber: 1 }), | ||
| }, | ||
| } as const satisfies AcceptanceTestBenchmarks; | ||
|
|
||
| export default depositAddresses; | ||
Binary file added
BIN
+110 KB
...data/apps/kucoin-exchange/benchmarks/resolution/ensv2-ready-resolution/ac-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
48 changes: 48 additions & 0 deletions
48
...ards.org/data/apps/kucoin-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md | ||
| // for additional advice on adding and modifying app benchmarks | ||
|
|
||
| import type { AcceptanceTestBenchmark } from "data/acceptance-tests/types"; | ||
| import type { AcceptanceTestBenchmarks } from "data/benchmarks/types"; | ||
| import { BenchmarkResults } from "data/benchmarks/types"; | ||
| import contributors from "data/contributors"; | ||
| import { acceptanceTestDetailsContainerStyles } from "data/ens-best-practices/styles"; | ||
|
|
||
| import { parseTimestamp } from "@ensnode/ensnode-sdk"; | ||
|
|
||
| import { cn } from "@/utils/tailwindClassConcatenation"; | ||
|
|
||
| import ensv2ProofImage from "./ac-2.png"; | ||
|
Y3drk marked this conversation as resolved.
Outdated
|
||
|
|
||
| const ensv2ReadyResolution = { | ||
| "correctly-resolve-ensv2-test-name-address": { | ||
| result: BenchmarkResults.NotApplicable, | ||
| contributions: [ | ||
| { | ||
| from: contributors.y3drk, | ||
| lastUpdated: parseTimestamp("2026-07-02T00:00:00Z"), | ||
| }, | ||
| ], | ||
| notes: ( | ||
| <div className={cn(acceptanceTestDetailsContainerStyles, "w-full")}> | ||
| <p className="w-full"> | ||
| ENSv2 ready resolution was tested using the "withdraw" feature on kucoin.com by | ||
| attempting to use "ur.integration-tests.eth" as the recipient identifier. The | ||
| app doesn't support the use of ENS names at all and rejects ENS input. | ||
|
Y3drk marked this conversation as resolved.
Outdated
|
||
| <br /> | ||
| <br /> | ||
| While that's a key issue that this app is encouraged to improve, this best practice is | ||
| applicable specifically to apps that already have an existing ENS integration and making | ||
| sure existing integrations are ENSv2 compatible. Therefore, for this best practice we | ||
| apply a rating of not applicable. | ||
| </p> | ||
| <img | ||
| alt="KuCoin exchange rejects ur.integration-tests.eth in the withdraw flow" | ||
| src={ensv2ProofImage.src} | ||
| className="w-auto h-full max-h-[325px] rounded-xl" | ||
| /> | ||
| </div> | ||
| ), | ||
| } as const satisfies AcceptanceTestBenchmark, | ||
| } as const satisfies AcceptanceTestBenchmarks; | ||
|
|
||
| export default ensv2ReadyResolution; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import React from "react"; | ||
|
|
||
| import { cn } from "@/utils/tailwindClassConcatenation"; | ||
|
|
||
| const Icon = ({ className, ...props }: React.SVGProps<SVGSVGElement>) => ( | ||
| <svg | ||
| fill="none" | ||
| height="40" | ||
| viewBox="0 0 40 40" | ||
| width="40" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| className={cn("p-1.5", className)} | ||
| {...props} | ||
| > | ||
| <rect fill="#01bc8d" height="40" rx="20" width="40" /> | ||
| <path | ||
| d="m15.9206 20 7.1057 7.1051 4.4903-4.4899c.7869-.7868 2.0831-.7868 2.87 0 .787.7869.787 2.083 0 2.8699l-5.9253 5.9247c-.7869.7869-2.0831.7869-2.87 0l-8.5177-8.54v5.0916c0 1.1109-.9026 2.0367-2.0368 2.0367-1.13412 0-2.0368-.9026-2.0368-2.0367v-15.8765c0-1.1341.90268-2.0367 2.0368-2.0367 1.1342 0 2.0368.9026 2.0368 2.0367v5.0453l8.5408-8.54004c.787-.78688 2.0831-.78688 2.8701 0l5.9253 5.92474c.7869.7869.7869 2.083 0 2.8699-.787.7868-2.0831.7868-2.8701 0l-4.4903-4.4899zm7.1288-2.0366c-1.1341 0-2.0368.9026-2.0368 2.0366s.9027 2.0366 2.0368 2.0366c1.1342 0 2.0369-.9026 2.0369-2.0366-.0232-1.134-.9259-2.0366-2.0369-2.0366z" | ||
| fill="#fff" | ||
| /> | ||
| </svg> | ||
| ); | ||
|
|
||
| export default Icon; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md | ||
| // for additional advice on adding and modifying apps | ||
|
|
||
| import KuCoinProject from "data/projects/kucoin"; | ||
|
|
||
| import { defineApp } from "../registry.ts"; | ||
| import { type App, AppTypes } from "../types.ts"; | ||
| import KuCoinIcon from "./icon.tsx"; | ||
|
|
||
| const KuCoinExchange: App = { | ||
| id: "kucoin-exchange", | ||
| appSlug: "kucoin-exchange", | ||
| type: AppTypes.Exchange, | ||
| project: KuCoinProject, | ||
| name: "KuCoin", | ||
| description: | ||
| "Cryptocurrency exchange app for buying, selling, and trading Bitcoin, Ethereum, and 1,000+ altcoins.", | ||
| socials: { | ||
| website: new URL("https://www.kucoin.com"), | ||
| twitter: new URL("https://x.com/KuCoinCom"), | ||
| }, | ||
| icon: KuCoinIcon, | ||
| // TODO: Add OG images | ||
| }; | ||
|
|
||
| defineApp(KuCoinExchange); | ||
|
|
||
| export default KuCoinExchange; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import React from "react"; | ||
|
|
||
| import { cn } from "@/utils/tailwindClassConcatenation"; | ||
|
|
||
| const Icon = ({ className, ...props }: React.SVGProps<SVGSVGElement>) => ( | ||
| <svg | ||
| fill="none" | ||
| height="40" | ||
| viewBox="0 0 40 40" | ||
| width="40" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| className={cn("p-1.5", className)} | ||
|
Y3drk marked this conversation as resolved.
Outdated
|
||
| {...props} | ||
| > | ||
| <rect fill="#01bc8d" height="40" rx="20" width="40" /> | ||
| <path | ||
| d="m15.9206 20 7.1057 7.1051 4.4903-4.4899c.7869-.7868 2.0831-.7868 2.87 0 .787.7869.787 2.083 0 2.8699l-5.9253 5.9247c-.7869.7869-2.0831.7869-2.87 0l-8.5177-8.54v5.0916c0 1.1109-.9026 2.0367-2.0368 2.0367-1.13412 0-2.0368-.9026-2.0368-2.0367v-15.8765c0-1.1341.90268-2.0367 2.0368-2.0367 1.1342 0 2.0368.9026 2.0368 2.0367v5.0453l8.5408-8.54004c.787-.78688 2.0831-.78688 2.8701 0l5.9253 5.92474c.7869.7869.7869 2.083 0 2.8699-.787.7868-2.0831.7868-2.8701 0l-4.4903-4.4899zm7.1288-2.0366c-1.1341 0-2.0368.9026-2.0368 2.0366s.9027 2.0366 2.0368 2.0366c1.1342 0 2.0369-.9026 2.0369-2.0366-.0232-1.134-.9259-2.0366-2.0369-2.0366z" | ||
| fill="#fff" | ||
| /> | ||
| </svg> | ||
| ); | ||
|
|
||
| export default Icon; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md | ||
| // for additional advice on adding and modifying projects | ||
|
|
||
| import { defineProject } from "../registry.ts"; | ||
| import type { Project } from "../types.ts"; | ||
| import { ProjectIds } from "../types.ts"; | ||
| import KuCoinIcon from "./icon.tsx"; | ||
|
|
||
| const KuCoinProject: Project = { | ||
| id: ProjectIds.KuCoin, | ||
| name: "KuCoin", | ||
| description: | ||
| "Trusted cryptocurrency exchange for buying, selling, and trading Bitcoin, Ethereum, and 1,000+ altcoins, with secure access to the Web3 economy.", | ||
| icon: KuCoinIcon, | ||
| socials: { | ||
| website: new URL("https://www.kucoin.com"), | ||
| twitter: new URL("https://x.com/KuCoinCom"), | ||
| }, | ||
| }; | ||
|
|
||
| defineProject(KuCoinProject); | ||
|
|
||
| export default KuCoinProject; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.