Skip to content
This repository was archived by the owner on Aug 5, 2026. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import FrameWallet from "data/apps/frame-wallet";
import { defineAppBenchmarks } from "data/benchmarks/registry";
import type { BestPracticeBenchmarks } from "data/ens-best-practices/types";

import depositAddresses from "./resolution/deposit-address";
import depositAddresses from "./resolution/deposit-addresses";
import ensv2ReadyResolution from "./resolution/ensv2-ready-resolution";

const benchmarks: BestPracticeBenchmarks = {
Expand Down

This file was deleted.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
// Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md
// for additional advice on adding and modifying app benchmarks

import { type AcceptanceTestBenchmarks, BenchmarkResults } from "data/benchmarks/types";
import contributors from "data/contributors";
import {
buildFailNoteForAT4,
buildFailNoteForAT5,
buildNotApplicableForFailedTest,
buildNotApplicableForNonEvmChain,
buildPassNoteForAT1,
buildPassNoteForAT2,
buildPassNoteForAT3,
} from "data/ens-best-practices/resolution/deposit-addresses/notes";

import { parseTimestamp } from "@ensnode/ensnode-sdk";

import at1Proof from "./at-1.png";
import at2Proof from "./at-2.png";
import at3Proof from "./at-3.png";
import at4Proof from "./at-4.png";
import at5Proof from "./at-5.png";

const method = 'the "send" flow';

const depositAddresses = {
"at01-resolve-onchain-name": {
result: BenchmarkResults.Pass,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildPassNoteForAT1({
method,
proof: {
image: at1Proof,
alt: "Frame Wallet correctly resolves the address for vitalik.eth",
},
}),
},
"at02-resolve-name-needing-normalization": {
result: BenchmarkResults.Pass,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildPassNoteForAT2({
method,
proof: {
image: at2Proof,
alt: "Frame Wallet correctly resolves the address for Ξthereum.eth",
},
}),
},
"at03-resolve-offchain-eth-subname": {
result: BenchmarkResults.Pass,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildPassNoteForAT3({
method,
proof: {
image: at3Proof,
alt: "Frame Wallet correctly resolves the address for jesse.base.eth",
},
}),
},
"at04-resolve-offchain-dns-name": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildFailNoteForAT4({
method,
proof: {
image: at4Proof,
alt: "Frame Wallet fails to resolve the address for dperri.com",
},
extra: 'The app showed the message "Recipient must be address or ENS name".',
}),
},
"at05-resolve-name-on-other-evm-chain": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildFailNoteForAT5({
method,
proof: {
image: at5Proof,
alt: "Frame Wallet fails to resolve the address for lightkeeper.eth on the Base chain",
},
extra: "The app resolved to the Ethereum Mainnet address instead of the Base address.",
}),
},
"at06-resolve-bitcoin-address": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildNotApplicableForNonEvmChain({ chain: "Bitcoin" }),
},
"at07-resolve-solana-address": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildNotApplicableForNonEvmChain({ chain: "Solana" }),
},
"at08-handle-invalid-address-format": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildNotApplicableForFailedTest({ testNumber: 5, scope: "on Base" }),
},
} as const satisfies AcceptanceTestBenchmarks;

export default depositAddresses;
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import KrakenWallet from "data/apps/kraken-wallet";
import { defineAppBenchmarks } from "data/benchmarks/registry";
import type { BestPracticeBenchmarks } from "data/ens-best-practices/types";

import depositAddresses from "./resolution/deposit-address";
import depositAddresses from "./resolution/deposit-addresses";
import ensv2ReadyResolution from "./resolution/ensv2-ready-resolution";

const benchmarks: BestPracticeBenchmarks = {
Expand Down

This file was deleted.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
// Read https://github.com/namehash/ensawards/blob/main/CONTRIBUTING.md
// for additional advice on adding and modifying app benchmarks

import { type AcceptanceTestBenchmarks, BenchmarkResults } from "data/benchmarks/types";
import contributors from "data/contributors";
import {
buildFailNoteForAT3,
buildFailNoteForAT4,
buildFailNoteForAT5,
buildFailNoteForAT6,
buildFailNoteForAT7,
buildNotApplicableForFailedTest,
buildPassNoteForAT1,
buildPassNoteForAT2,
} from "data/ens-best-practices/resolution/deposit-addresses/notes";

import { parseTimestamp } from "@ensnode/ensnode-sdk";

import at1Proof from "./at-1.png";
import at2Proof from "./at-2.png";
import at3Proof from "./at-3.png";
import at4Proof from "./at-4.png";
import at5Proof from "./at-5.png";
import at6Proof from "./at-6.png";
import at7Proof from "./at-7.png";

const method = 'the "send" flow';

const depositAddresses = {
"at01-resolve-onchain-name": {
result: BenchmarkResults.Pass,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildPassNoteForAT1({
method,
proof: {
image: at1Proof,
alt: "Kraken Wallet correctly resolves the address for vitalik.eth",
},
}),
},
"at02-resolve-name-needing-normalization": {
result: BenchmarkResults.Pass,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildPassNoteForAT2({
method,
proof: {
image: at2Proof,
alt: "Kraken Wallet correctly resolves the address for Ξthereum.eth",
},
}),
},
"at03-resolve-offchain-eth-subname": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildFailNoteForAT3({
method,
proof: {
image: at3Proof,
alt: "Kraken Wallet fails to resolve the address for jesse.base.eth",
},
extra: 'The app showed the message "Invalid address".',
}),
},
"at04-resolve-offchain-dns-name": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildFailNoteForAT4({
method,
proof: {
image: at4Proof,
alt: "Kraken Wallet fails to resolve the address for dperri.com",
},
extra: 'The app showed the message "Invalid address".',
}),
},
"at05-resolve-name-on-other-evm-chain": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildFailNoteForAT5({
method,
proof: {
image: at5Proof,
alt: "Kraken Wallet fails to resolve the address for lightkeeper.eth on the Base chain",
},
extra: "The app resolved to the Ethereum Mainnet address instead of the Base address.",
}),
},
"at06-resolve-bitcoin-address": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildFailNoteForAT6({
method: 'the "send" flow in context of the Bitcoin chain',
proof: {
image: at6Proof,
alt: "Kraken Wallet fails to resolve the Bitcoin address for gregskril.eth",
},
extra: 'The app showed the message "Invalid address".',
}),
},
"at07-resolve-solana-address": {
result: BenchmarkResults.Fail,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildFailNoteForAT7({
method: 'the "send" flow in context of the Solana chain',
proof: {
image: at7Proof,
alt: "Kraken Wallet fails to resolve the Solana address for gregskril.eth",
},
extra: 'The app showed the message "Invalid address".',
}),
},
"at08-handle-invalid-address-format": {
result: BenchmarkResults.NotApplicable,
contributions: [
{ from: contributors.y3drk, lastUpdated: parseTimestamp("2026-06-23T15:06:39Z") },
],
notes: buildNotApplicableForFailedTest({ testNumber: 5, scope: "on Base" }),
},
} as const satisfies AcceptanceTestBenchmarks;

export default depositAddresses;
Loading