Conversation
* Action Item 1 * Action Item 2 * Apply 06/18/26 GitHub review feedback & AI agents' suggestions, pt.1 * Apply AI agents' suggestions, pt.2
* Action Item 1 * Action Item 2 * Apply 06/18/26 GitHub review feedback & AI agents' suggestions, pt.1 * Add etherscan acceptance test for deposit address * revert mockedExampleBenchmark * delete file * oops * add not-applicable --------- Co-authored-by: y3drk <ziebura.jedrzej@gmail.com>
* add skill to rearrange app benchmark * rearrange blockscout-explorer to new structure * add blockscout-explorer case * p lint * rearrange 1inch-defi benchmark to new structure * update skill to use values from technicalDetails * generate benchmark for 1inch * p lint * update benchmark of blockscout and etherscan accordingly * apply fixes for AI review
* Action Item 1 * Action Item 2 * Apply 06/18/26 GitHub review feedback & AI agents' suggestions, pt.1 * Add benchmarks for ambire + example pass for AT1 and example fail for AT4 * Add benchmarks for binance wallet + example fail for AT1 * Add benchmarks for coinbase wallet * Add benchmarks for readyx * Add benchmarks for world app wallet * Add benchmarks for robinhood wallet * Adjust benchmarked apps to the newly established structure * Add benchmarks for zerion * Add benchmarks for walletchan * unify code with my PR * p lint * add more images or at-2 in zerion --------- Co-authored-by: sevenzing <lymarenko.lev@gmail.com>
* rename ATs and use notes.tsx to remove boilerplate * rename images * add indexed key * apply greptile feedback
* rearrange to new structure * remove useless skill * p lint
* add aave and uniswap * fix uniswap case * add lido * yeah i forgot at7 and 8 * just rename deposit-address -> deposit-addresses
…#241) * Add benchmarks for okx wallet & crypto.com wallet + add bitcoin benchmark for coinbase wallet + add example passes for ATs 5-8 * Add benchmarks for phantom & rabby + add example pass for AT2 and example fails for ATs 3 & 5 * Update method context notes for AT5 pass/fail template * Add benchmarks for safe{wallet} + add extra explanations for failed benchmarks + add example pass for AT3 * Add benchmarks for gemini wallet & metamask + update CONTRIBUTING.md + add example fails for ATs 2 & 8 * Apply AI agents' suggestions, pt.1
* add benchmarks for raibow-wallet,status-wallet,trust-wallet * rename to deposit-addresses
…d example fails for ATs 6 & 7 (#242)
|
Too many files changed for review. ( |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 7 minutes and 33 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds the deposit-addresses ENS best practice and shared note builders, updates benchmark-generation guidance and benchmark sorting metadata, refactors many app benchmark registries to import modular files, adds per-app deposit-addresses and ENSv2 benchmark modules, adds WalletChan contract-naming modules, registers Bybit Exchange, and updates related redirects/docs. ChangesBenchmark modularization and best-practice expansion
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/generate-app-benchmark/SKILL.md:
- Line 30: The fenced code blocks at lines 30, 47, 57, and 93 in the SKILL.md
file are missing language identifiers, which violates the markdownlint MD040
rule. Add the appropriate language identifier after the opening triple backticks
for each unlabeled code block (for example, use ```text, ```bash, ```json,
```tsx, etc., depending on the content type of each block) to make the
documentation lint-clean.
In `@ensawards.org/data/apps/binance-exchange/benchmarks/index.tsx`:
- Around line 11-14: The benchmarks object is missing two keys that are present
in all other sibling app registries for consistency. Add the two missing entries
to the benchmarks object: "display-named-smart-contracts-mainnet" and
"display-named-smart-contracts-l2-chains", both with undefined values. These
keys are part of the Contract Naming category which is temporarily hidden, as
documented in the related TODO comments and issue tracking.
In
`@ensawards.org/data/apps/walletchan-wallet/benchmarks/contract-naming/display-named-smart-contracts-l2-chains/index.tsx`:
- Around line 20-35: The benchmark entry
"l2-chain-interactions-display-named-smart-contracts" is marked as
BenchmarkResults.Pass but contains placeholder content in the notes field with a
TODO comment and uses exampleProofImage instead of actual proof. Either replace
the TODO text in the notes section with real benchmark notes and update the img
src to reference actual proof evidence, or set the entire benchmark object to
undefined if the real evidence is not yet available. Do not merge with
placeholder content marked as Pass.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: e4f924a1-dabb-4f13-9475-4cd4c5a765e5
⛔ Files ignored due to path filters (185)
ensawards.org/data/apps/1inch-defi/benchmarks/resolution/deposit-address/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/1inch-defi/benchmarks/resolution/deposit-address/at-2.gifis excluded by!**/*.gifensawards.org/data/apps/1inch-defi/benchmarks/resolution/deposit-address/at-3.gifis excluded by!**/*.gifensawards.org/data/apps/1inch-defi/benchmarks/resolution/deposit-address/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/1inch-defi/benchmarks/resolution/deposit-address/at-5.gifis excluded by!**/*.gifensawards.org/data/apps/1inch-defi/benchmarks/resolution/deposit-address/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/1inch-defi/benchmarks/resolution/ensv2-ready-resolution/ac-1.1.gifis excluded by!**/*.gifensawards.org/data/apps/1inch-defi/benchmarks/resolution/ensv2-ready-resolution/ac-1.2.pngis excluded by!**/*.pngensawards.org/data/apps/aave-defi/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/aave-defi/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/aave-defi/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/aave-defi/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/aave-defi/benchmarks/resolution/ensv2-ready-resolution/ac-1.gifis excluded by!**/*.gifensawards.org/data/apps/aave-defi/benchmarks/resolution/ensv2-ready-resolution/ac-2.pngis excluded by!**/*.pngensawards.org/data/apps/ambire-wallet/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/ambire-wallet/benchmarks/resolution/deposit-addresses/at-2.gifis excluded by!**/*.gifensawards.org/data/apps/ambire-wallet/benchmarks/resolution/deposit-addresses/at-3.gifis excluded by!**/*.gifensawards.org/data/apps/ambire-wallet/benchmarks/resolution/deposit-addresses/at-4.gifis excluded by!**/*.gifensawards.org/data/apps/ambire-wallet/benchmarks/resolution/deposit-addresses/at-5.gifis excluded by!**/*.gifensawards.org/data/apps/ambire-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/ambire-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/ambire-wallet/benchmarks/resolution/deposit-addresses/at-8.gifis excluded by!**/*.gifensawards.org/data/apps/ambire-wallet/benchmarks/resolution/ensv2-ready-resolution/correctly-resolve-ensv2-test-name-address-proof.pngis excluded by!**/*.pngensawards.org/data/apps/binance-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/binance-exchange/benchmarks/resolution/ensv2-ready-resolution/ac-1.gifis excluded by!**/*.gifensawards.org/data/apps/binance-exchange/benchmarks/resolution/ensv2-ready-resolution/ac-2.pngis excluded by!**/*.pngensawards.org/data/apps/binance-wallet/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/binance-wallet/benchmarks/resolution/ensv2-ready-resolution/correctly-resolve-ensv2-test-name-address-proof.gifis excluded by!**/*.gifensawards.org/data/apps/blockscout-explorer/benchmarks/resolution/deposit-address/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/blockscout-explorer/benchmarks/resolution/deposit-address/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/blockscout-explorer/benchmarks/resolution/deposit-address/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/blockscout-explorer/benchmarks/resolution/deposit-address/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/blockscout-explorer/benchmarks/resolution/deposit-address/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/blockscout-explorer/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/bybit-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bybit-exchange/benchmarks/resolution/ensv2-ready-resolution/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/bybit-exchange/og.pngis excluded by!**/*.pngensawards.org/data/apps/bybit-exchange/twitter-og.pngis excluded by!**/*.pngensawards.org/data/apps/coinbase-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/coinbase-exchange/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/coinbase-exchange/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/coinbase-exchange/benchmarks/resolution/deposit-addresses/at-4.gifis excluded by!**/*.gifensawards.org/data/apps/coinbase-exchange/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/coinbase-exchange/benchmarks/resolution/deposit-addresses/at-7.gifis excluded by!**/*.gifensawards.org/data/apps/coinbase-exchange/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/coinbase-wallet/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/coinbase-wallet/benchmarks/resolution/deposit-addresses/at-2.gifis excluded by!**/*.gifensawards.org/data/apps/coinbase-wallet/benchmarks/resolution/deposit-addresses/at-3.gifis excluded by!**/*.gifensawards.org/data/apps/coinbase-wallet/benchmarks/resolution/deposit-addresses/at-4.gifis excluded by!**/*.gifensawards.org/data/apps/coinbase-wallet/benchmarks/resolution/deposit-addresses/at-5.gifis excluded by!**/*.gifensawards.org/data/apps/coinbase-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/coinbase-wallet/benchmarks/resolution/deposit-addresses/at-7.gifis excluded by!**/*.gifensawards.org/data/apps/coinbase-wallet/benchmarks/resolution/ensv2-ready-resolution/correctly-resolve-ensv2-test-name-address-proof.gifis excluded by!**/*.gifensawards.org/data/apps/cryptocom-exchange/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/cryptocom-exchange/benchmarks/resolution/ensv2-ready-resolution/ac-1.gifis excluded by!**/*.gifensawards.org/data/apps/cryptocom-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/cryptocom-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/cryptocom-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/cryptocom-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/cryptocom-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/cryptocom-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/cryptocom-wallet/benchmarks/resolution/deposit-addresses/at-8.pngis excluded by!**/*.pngensawards.org/data/apps/cryptocom-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/etherscan-explorer/benchmarks/resolution/deposit-address/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/etherscan-explorer/benchmarks/resolution/deposit-address/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/etherscan-explorer/benchmarks/resolution/deposit-address/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/etherscan-explorer/benchmarks/resolution/deposit-address/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/etherscan-explorer/benchmarks/resolution/deposit-address/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/etherscan-explorer/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/frame-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/gemini-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/gemini-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/gemini-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/gemini-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/gemini-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/gemini-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/kraken-exchange/benchmarks/resolution/ensv2-ready-resolution/ac-1.gifis excluded by!**/*.gifensawards.org/data/apps/kraken-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/lido-defi/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/lido-defi/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/lido-defi/benchmarks/resolution/ensv2-ready-resolution/ac-2.pngis excluded by!**/*.pngensawards.org/data/apps/metamask-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/metamask-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/metamask-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/metamask-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/metamask-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/metamask-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/metamask-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/metamask-wallet/benchmarks/resolution/deposit-addresses/at-8.pngis excluded by!**/*.pngensawards.org/data/apps/metamask-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/okx-exchange/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/okx-exchange/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/okx-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/okx-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/okx-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/okx-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/okx-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/okx-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/okx-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/okx-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/phantom-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/phantom-wallet/benchmarks/resolution/deposit-addresses/at-2.gifis excluded by!**/*.gifensawards.org/data/apps/phantom-wallet/benchmarks/resolution/deposit-addresses/at-3.gifis excluded by!**/*.gifensawards.org/data/apps/phantom-wallet/benchmarks/resolution/deposit-addresses/at-4.gifis excluded by!**/*.gifensawards.org/data/apps/phantom-wallet/benchmarks/resolution/deposit-addresses/at-5.gifis excluded by!**/*.gifensawards.org/data/apps/phantom-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/phantom-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/phantom-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.gifis excluded by!**/*.gifensawards.org/data/apps/rabby-wallet/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/rabby-wallet/benchmarks/resolution/deposit-addresses/at-2.gifis excluded by!**/*.gifensawards.org/data/apps/rabby-wallet/benchmarks/resolution/deposit-addresses/at-3.gifis excluded by!**/*.gifensawards.org/data/apps/rabby-wallet/benchmarks/resolution/deposit-addresses/at-4.gifis excluded by!**/*.gifensawards.org/data/apps/rabby-wallet/benchmarks/resolution/deposit-addresses/at-5.gifis excluded by!**/*.gifensawards.org/data/apps/rabby-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.gifis excluded by!**/*.gifensawards.org/data/apps/rainbow-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/rainbow-wallet/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/rainbow-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/rainbow-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/rainbow-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/rainbow-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/readyx-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/readyx-wallet/benchmarks/resolution/ensv2-ready-resolution/correctly-resolve-ensv2-test-name-address-proof.pngis excluded by!**/*.pngensawards.org/data/apps/robinhood-exchange/benchmarks/resolution/deposit-addresses/at-1.1.pngis excluded by!**/*.pngensawards.org/data/apps/robinhood-exchange/benchmarks/resolution/deposit-addresses/at-1.2.pngis excluded by!**/*.pngensawards.org/data/apps/robinhood-exchange/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/robinhood-exchange/benchmarks/resolution/ensv2-ready-resolution/ac-2.pngis excluded by!**/*.pngensawards.org/data/apps/robinhood-wallet/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/robinhood-wallet/benchmarks/resolution/ensv2-ready-resolution/correctly-resolve-ensv2-test-name-address-proof.gifis excluded by!**/*.gifensawards.org/data/apps/safe-wallet/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/safe-wallet/benchmarks/resolution/deposit-addresses/at-2.gifis excluded by!**/*.gifensawards.org/data/apps/safe-wallet/benchmarks/resolution/deposit-addresses/at-3.gifis excluded by!**/*.gifensawards.org/data/apps/safe-wallet/benchmarks/resolution/deposit-addresses/at-4.gifis excluded by!**/*.gifensawards.org/data/apps/safe-wallet/benchmarks/resolution/deposit-addresses/at-5.gifis excluded by!**/*.gifensawards.org/data/apps/safe-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.gifis excluded by!**/*.gifensawards.org/data/apps/status-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/status-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/trust-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/trust-wallet/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-defi/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-defi/benchmarks/resolution/deposit-addresses/at-2.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-defi/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-defi/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-defi/benchmarks/resolution/deposit-addresses/at-5.gifis excluded by!**/*.gifensawards.org/data/apps/uniswap-defi/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/uniswap-defi/benchmarks/resolution/ensv2-ready-resolution/ac-1.pngis excluded by!**/*.pngensawards.org/data/apps/walletchan-wallet/benchmarks/contract-naming/display-named-smart-contracts-l2-chains/acceptance-test-benchmark-proof-example.pngis excluded by!**/*.pngensawards.org/data/apps/walletchan-wallet/benchmarks/contract-naming/display-named-smart-contracts-mainnet/named-smart-contracts-on-mainnet-proof.pngis excluded by!**/*.pngensawards.org/data/apps/walletchan-wallet/benchmarks/resolution/deposit-addresses/at-1.gifis excluded by!**/*.gifensawards.org/data/apps/walletchan-wallet/benchmarks/resolution/deposit-addresses/at-2.gifis excluded by!**/*.gifensawards.org/data/apps/walletchan-wallet/benchmarks/resolution/deposit-addresses/at-3.gifis excluded by!**/*.gifensawards.org/data/apps/walletchan-wallet/benchmarks/resolution/deposit-addresses/at-4.gifis excluded by!**/*.gifensawards.org/data/apps/walletchan-wallet/benchmarks/resolution/deposit-addresses/at-5.gifis excluded by!**/*.gifensawards.org/data/apps/walletchan-wallet/benchmarks/resolution/ensv2-ready-resolution/correctly-resolve-ensv2-test-name-address-proof.pngis excluded by!**/*.pngensawards.org/data/apps/worldapp-wallet/benchmarks/resolution/deposit-addresses/at-1-1.pngis excluded by!**/*.pngensawards.org/data/apps/worldapp-wallet/benchmarks/resolution/deposit-addresses/at-1-2.pngis excluded by!**/*.pngensawards.org/data/apps/worldapp-wallet/benchmarks/resolution/ensv2-ready-resolution/correctly-resolve-ensv2-test-name-address-proof-1.pngis excluded by!**/*.pngensawards.org/data/apps/worldapp-wallet/benchmarks/resolution/ensv2-ready-resolution/correctly-resolve-ensv2-test-name-address-proof-2.pngis excluded by!**/*.pngensawards.org/data/apps/zerion-wallet/benchmarks/resolution/deposit-addresses/at-1.pngis excluded by!**/*.pngensawards.org/data/apps/zerion-wallet/benchmarks/resolution/deposit-addresses/at-2.1.pngis excluded by!**/*.pngensawards.org/data/apps/zerion-wallet/benchmarks/resolution/deposit-addresses/at-2.2.pngis excluded by!**/*.pngensawards.org/data/apps/zerion-wallet/benchmarks/resolution/deposit-addresses/at-3.pngis excluded by!**/*.pngensawards.org/data/apps/zerion-wallet/benchmarks/resolution/deposit-addresses/at-4.pngis excluded by!**/*.pngensawards.org/data/apps/zerion-wallet/benchmarks/resolution/deposit-addresses/at-5.pngis excluded by!**/*.pngensawards.org/data/apps/zerion-wallet/benchmarks/resolution/deposit-addresses/at-6.pngis excluded by!**/*.pngensawards.org/data/apps/zerion-wallet/benchmarks/resolution/deposit-addresses/at-7.pngis excluded by!**/*.pngensawards.org/data/apps/zerion-wallet/benchmarks/resolution/ensv2-ready-resolution/correctly-resolve-ensv2-test-name-address-proof.pngis excluded by!**/*.pngensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at01-resolve-onchain-name-example-fail.gifis excluded by!**/*.gifensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at01-resolve-onchain-name-example-pass.gifis excluded by!**/*.gifensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at02-resolve-name-needing-normalization-example-fail.pngis excluded by!**/*.pngensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at02-resolve-name-needing-normalization-example-pass.gifis excluded by!**/*.gifensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at03-resolve-offchain-eth-subname-example-fail.gifis excluded by!**/*.gifensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at03-resolve-offchain-eth-subname-example-pass.gifis excluded by!**/*.gifensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at04-resolve-offchain-dns-name-example-fail.gifis excluded by!**/*.gifensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at04-resolve-offchain-dns-name-example-pass.gifis excluded by!**/*.gifensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at05-resolve-name-on-other-evm-chain-example-fail.gifis excluded by!**/*.gifensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at05-resolve-name-on-other-evm-chain-example-pass.pngis excluded by!**/*.pngensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at06-resolve-bitcoin-address-example-fail.pngis excluded by!**/*.pngensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at06-resolve-bitcoin-address-example-pass.pngis excluded by!**/*.pngensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at07-resolve-solana-address-example-fail.gifis excluded by!**/*.gifensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at07-resolve-solana-address-example-pass.pngis excluded by!**/*.pngensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at08-handle-invalid-address-format-example-fail.pngis excluded by!**/*.pngensawards.org/data/ens-best-practices/resolution/deposit-addresses/images/at08-handle-invalid-address-format-example-pass.pngis excluded by!**/*.pngensawards.org/data/ens-best-practices/resolution/ensv2-ready-resolution/images/correctly-resolve-ensv2-test-name-address-fail-example.pngis excluded by!**/*.pngensawards.org/data/ens-best-practices/resolution/ensv2-ready-resolution/images/correctly-resolve-ensv2-test-name-address-not-applicable-example.gifis excluded by!**/*.gifensawards.org/data/ens-best-practices/resolution/ensv2-ready-resolution/images/correctly-resolve-ensv2-test-name-address-pass-example.gifis excluded by!**/*.gif
📒 Files selected for processing (115)
.agents/skills/generate-app-benchmark/SKILL.md.gitignoreCONTRIBUTING.mdensawards.org/astro.config.mjsensawards.org/data/acceptance-tests/types.tsensawards.org/data/apps/1inch-defi/benchmarks/index.tsxensawards.org/data/apps/1inch-defi/benchmarks/resolution/deposit-address/index.tsxensawards.org/data/apps/1inch-defi/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/aave-defi/benchmarks/index.tsxensawards.org/data/apps/aave-defi/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/aave-defi/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/ambire-wallet/benchmarks/index.tsxensawards.org/data/apps/ambire-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/ambire-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/binance-exchange/benchmarks/index.tsxensawards.org/data/apps/binance-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/binance-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/binance-wallet/benchmarks/index.tsxensawards.org/data/apps/binance-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/binance-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/blockscout-explorer/benchmarks/index.tsxensawards.org/data/apps/blockscout-explorer/benchmarks/resolution/deposit-address/index.tsxensawards.org/data/apps/blockscout-explorer/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/bybit-exchange/benchmarks/index.tsxensawards.org/data/apps/bybit-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/bybit-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/bybit-exchange/icon.tsxensawards.org/data/apps/bybit-exchange/index.tsensawards.org/data/apps/coinbase-exchange/benchmarks/index.tsxensawards.org/data/apps/coinbase-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/coinbase-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/coinbase-wallet/benchmarks/index.tsxensawards.org/data/apps/coinbase-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/coinbase-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/cryptocom-exchange/benchmarks/index.tsxensawards.org/data/apps/cryptocom-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/cryptocom-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/cryptocom-wallet/benchmarks/index.tsxensawards.org/data/apps/cryptocom-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/cryptocom-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/etherscan-explorer/benchmarks/index.tsxensawards.org/data/apps/etherscan-explorer/benchmarks/resolution/deposit-address/index.tsxensawards.org/data/apps/etherscan-explorer/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/frame-wallet/benchmarks/index.tsxensawards.org/data/apps/frame-wallet/benchmarks/resolution/deposit-address/index.tsxensawards.org/data/apps/frame-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/gemini-wallet/benchmarks/index.tsxensawards.org/data/apps/gemini-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/gemini-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/kraken-exchange/benchmarks/index.tsxensawards.org/data/apps/kraken-exchange/benchmarks/resolution/deposit-address/index.tsxensawards.org/data/apps/kraken-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/kraken-wallet/benchmarks/index.tsxensawards.org/data/apps/kraken-wallet/benchmarks/resolution/deposit-address/index.tsxensawards.org/data/apps/kraken-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/lido-defi/benchmarks/index.tsxensawards.org/data/apps/lido-defi/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/lido-defi/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/metamask-wallet/benchmarks/index.tsxensawards.org/data/apps/metamask-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/metamask-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/okx-exchange/benchmarks/index.tsxensawards.org/data/apps/okx-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/okx-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/okx-wallet/benchmarks/index.tsxensawards.org/data/apps/okx-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/okx-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/phantom-wallet/benchmarks/index.tsxensawards.org/data/apps/phantom-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/phantom-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/rabby-wallet/benchmarks/index.tsxensawards.org/data/apps/rabby-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/rabby-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/rainbow-wallet/benchmarks/index.tsxensawards.org/data/apps/rainbow-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/rainbow-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/readyx-wallet/benchmarks/index.tsxensawards.org/data/apps/readyx-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/readyx-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/robinhood-exchange/benchmarks/index.tsxensawards.org/data/apps/robinhood-exchange/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/robinhood-exchange/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/robinhood-wallet/benchmarks/index.tsxensawards.org/data/apps/robinhood-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/robinhood-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/safe-wallet/benchmarks/index.tsxensawards.org/data/apps/safe-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/safe-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/status-wallet/benchmarks/index.tsxensawards.org/data/apps/status-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/status-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/trust-wallet/benchmarks/index.tsxensawards.org/data/apps/trust-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/trust-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/uniswap-defi/benchmarks/index.tsxensawards.org/data/apps/uniswap-defi/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/uniswap-defi/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/walletchan-wallet/benchmarks/contract-naming/display-named-smart-contracts-l2-chains/index.tsxensawards.org/data/apps/walletchan-wallet/benchmarks/contract-naming/display-named-smart-contracts-mainnet/index.tsxensawards.org/data/apps/walletchan-wallet/benchmarks/index.tsxensawards.org/data/apps/walletchan-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/walletchan-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/worldapp-wallet/benchmarks/index.tsxensawards.org/data/apps/worldapp-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/worldapp-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/apps/zerion-wallet/benchmarks/index.tsxensawards.org/data/apps/zerion-wallet/benchmarks/resolution/deposit-addresses/index.tsxensawards.org/data/apps/zerion-wallet/benchmarks/resolution/ensv2-ready-resolution/index.tsxensawards.org/data/contributors/index.tsensawards.org/data/ens-best-practices/contract-naming/display-named-smart-contracts-l2-chains/technicalDetails.tsxensawards.org/data/ens-best-practices/contract-naming/display-named-smart-contracts-mainnet/technicalDetails.tsxensawards.org/data/ens-best-practices/contract-naming/name-your-smart-contracts/technicalDetails.tsxensawards.org/data/ens-best-practices/resolution/deposit-addresses/index.tsensawards.org/data/ens-best-practices/resolution/deposit-addresses/notes.tsxensawards.org/data/ens-best-practices/resolution/deposit-addresses/technicalDetails.tsx
lightwalker-eth
left a comment
There was a problem hiding this comment.
@Y3drk @sevenzing Super job guys! Let's ship it 🚀
Merges
dev/acbranch intomainwith following PRs:deposit-addressbest practice #233deposit-addressesbest practice #236deposit-addressesbest practice, batch 2 #241binance,bybitandokx#240deposit-addressesbest practice, batch 2 #242