Skip to content

Fix linter errors and spelling/grammar errors; add new linter rules#303

Open
zaz wants to merge 10 commits intogeometric-intelligence:mainfrom
zaz:lint
Open

Fix linter errors and spelling/grammar errors; add new linter rules#303
zaz wants to merge 10 commits intogeometric-intelligence:mainfrom
zaz:lint

Conversation

@zaz
Copy link
Copy Markdown

@zaz zaz commented Apr 10, 2026

Checklist

  • My pull request has a clear and explanatory title.
  • My pull request passes the Linting test.
  • I added appropriate unit tests and I made sure the code passes all unit tests. (refer to comment below)
  • My PR follows PEP8 guidelines. (refer to comment below)
  • My code is properly documented, using numpy docs conventions, and I made sure the documentation renders properly.
  • I linked to issues and PRs that are relevant to this PR.

PR series: 303 #307 #308 #309

This PR is first in series of staged PRs designed to be merged in-order.
I prefer to get lint issues out of the way first to avoid ongoing nuisance when rebasing.

Description

All of the new linters added are just one line each in .pre-commit-config.yaml and require no new dependencies.


Note

Low Risk
Low risk: changes are primarily formatting/whitespace normalization and documentation/config cleanups, plus additional pre-commit hooks that may surface new lint failures but do not alter runtime behavior.

Overview
Linter tooling: Expands .pre-commit-config.yaml to run additional pre-commit-hooks checks (e.g., EOF fixing, trailing whitespace, AST/JSON/symlink checks) alongside existing Ruff and NumPy doc validation.

Repo hygiene: Normalizes formatting across many YAML/Markdown/RST/test files (trailing spaces, blank lines, missing final newlines) and makes small copy edits in README.md and docs; includes minor config housekeeping like ensuring uv.lock is ignored and tidying Codecov/GitHub Actions YAML formatting.

Reviewed by Cursor Bugbot for commit 8d37acd. Bugbot is set up for automated code reviews on this repo. Configure here.

"ensuring uv.lock is ignored". We just add a newline to the end of uv.lock because it's at the end of the file; no functional changes to the gitignore or anything else.

zaz added 5 commits April 10, 2026 15:56
Run `pre-commit run --all-files`.
Fixes linter warning: numpydoc-validation flagged mismatched
underline lengths in docstring section headers.
Fixes linter warning: numpydoc-validation flagged GL08 (missing
docstring) on 4 modules.
Run `pre-commit run --all-files`.
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f606810. Configure here.

Comment thread .pre-commit-config.yaml
zaz and others added 5 commits April 10, 2026 18:03
After adding these, running `pre-commit run --all-files` indicates
no existing issues.
Run `codespell --write-changes`, then manually correct.
Fix grammar using Claude Haiku 4.5, then manually correct.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant