Fix issue where setup script can close the user's terminal#307
Open
zaz wants to merge 12 commits intogeometric-intelligence:mainfrom
Open
Fix issue where setup script can close the user's terminal#307zaz wants to merge 12 commits intogeometric-intelligence:mainfrom
zaz wants to merge 12 commits intogeometric-intelligence:mainfrom
Conversation
Run `pre-commit run --all-files`.
Fixes linter warning: numpydoc-validation flagged mismatched underline lengths in docstring section headers.
Fixes linter warning: numpydoc-validation flagged GL08 (missing docstring) on 4 modules.
Run `pre-commit run --all-files`.
Run `pre-commit run --all-files`.
After adding these, running `pre-commit run --all-files` indicates no existing issues.
Run `codespell --write-changes`, then manually correct.
Fix grammar using Claude Haiku 4.5, then manually correct. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Use `return 1` instead of `exit 1` so that sourcing the script with an invalid platform prints the error without killing the shell. Fixes geometric-intelligence#305
Verify that `source uv_env_setup.sh INVALID` does not kill the user's shell (uses return instead of exit).
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
PR series: #303 307 #308 #309
This PR is only for commits 193bac1..02bcc2c. It is number 2 in a series of staged PRs, building upon #303 by adding commits 193bac1..02bcc2c; if #303 is rejected, these commits can be cherry-picked.
Description
Commits:
returninstead ofexit; the exact same pattern that is used elsewhere in the file. Simple, one-line change.Issue
Fixes #305.
Note
Low Risk
Low risk: changes are primarily whitespace/EOL normalization, minor wording fixes, and adding pre-commit hooks; no functional runtime logic is altered beyond developer tooling and tests/docs.
Overview
Normalizes formatting across the repo by fixing missing end-of-file newlines and trailing whitespace in many YAML configs, docs, scripts, and tests.
Strengthens contributor tooling by expanding
.pre-commit-config.yamlwith standard hygiene checks (EOF fixer, trailing whitespace, AST/JSON/symlink checks) and aligning CI/workflow/config files accordingly (e.g.,.gitignoreforuv.lock, minor workflow/codecov YAML cleanup).Reviewed by Cursor Bugbot for commit 193bac1. Bugbot is set up for automated code reviews on this repo. Configure here.