Closed
Conversation
Replace if/elif chain with case statement and string concatenation. No functional changes.
torch >= 2.6 defaults to weights_only=True, which breaks OGB's torch.load calls that serialize PyG data classes. Register the needed classes as safe globals so datasets load without errors. Guarded with hasattr for compatibility with torch < 2.6.
Prevents PyG's fs.torch_load from falling back to weights_only=False when loading processed datasets that contain numpy scalars and dtypes. Includes numpy.dtypes.*DType subclasses for numpy >= 1.25.
torch.tensor(existing_tensor) is deprecated; use .detach().clone(). nx.from_numpy_matrix is removed in NetworkX 3.0; use from_numpy_array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
PR series: #303 #305 306
This PR is only for commits 1b244e5..70959fc. It is number 3 in a series of staged PRs, building upon #305 by adding commits 1b244e5..70959fc; if #305 is rejected, the commits in this PR need to be reviewed.
Description
This PR fixes deprecation warnings in preparation for my subsequent PR to unpin torch. It includes commits
torch.load. This is good practice vs. allowing PyG to fall back toweights_only=False. Currently this provides no security benefit, but it will do in the future if my PyG PR is accepted.Overall, the 4 commits in this PR should be fairly benign, reduce various warning messages, and make TopoBench more amenable to upgrade beyond torch 2.3.0.
Issue
This is preparation for fixing issue #306