Fix: kraken2 builder: update URLs#7883
Open
jakobnissen wants to merge 2 commits intogalaxyproject:mainfrom
Open
Fix: kraken2 builder: update URLs#7883jakobnissen wants to merge 2 commits intogalaxyproject:mainfrom
jakobnissen wants to merge 2 commits intogalaxyproject:mainfrom
Conversation
The generated URLs does not correspond to the actual URLs where the data is stored. This makes building about 21 of the databases fail, e.g. the standard 8 GB from 2025-10-15. In this fix, I used the webpage https://benlangmead.github.io/aws-indexes/k2 to check the actual URLs, and verified each of them responds (but did not download every database to check it actually contains the correct file).
Commit 797b5fc changed data_managers/data_manager_build_kraken2_database/ data_manager/kraken2_build_database.xml#59 from the deprecated datetime.utcnow() to datetime.now(datetime.UTC). However, datetime.UTC was introduced in Python 3.11, making this tool break on systems with earlier Python versions. This fix should behave identically and support back to Python 3.2, long before Galaxy's minimum Python version of 3.9
5 tasks
Contributor
|
Thanks for the contribution. I was thinking if we should add a hidden test parameter, that could trigger the use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the kraken2 builder with two changes:
Fix generated URLs
The generated URLs does not correspond to the actual URLs where the data is stored. This makes building about 21 of the databases fail, e.g. the standard 8 GB from 2025-10-15.
In this fix, I used the webpage https://benlangmead.github.io/aws-indexes/k2 to check the actual URLs, and verified each of them responds (but did not download every database to check it actually contains the correct file).
Fix Python compat
Commit 797b5fc changed data_managers/data_manager_build_kraken2_database/
data_manager/kraken2_build_database.xml#59 from the deprecated
datetime.utcnow() to datetime.now(datetime.UTC). However, datetime.UTC was
introduced in Python 3.11, making this tool break on systems with earlier
Python versions.
This fix should behave identically and support back to Python 3.2, long before
Galaxy's minimum Python version of 3.9
Note that local tests fail due to what I think are unrelated reasons - flaky networking not related to the URLs updated in this PR.
FOR CONTRIBUTOR:
Fixes broken URL for existing tool