kraken2 builder: Fix Python compatibility#7880
Closed
jakobnissen wants to merge 1 commit intogalaxyproject:mainfrom
Closed
kraken2 builder: Fix Python compatibility#7880jakobnissen wants to merge 1 commit intogalaxyproject:mainfrom
jakobnissen wants to merge 1 commit intogalaxyproject:mainfrom
Conversation
Commit 797b5fc changed data_managers/data_manager_build_kraken2_database/ data_manager/kraken2_build_database.xml#59 from the deprecated datetime.utcnow() to datetime.now(datetime.UTC). However, datetime.UTC was introduced in Python 3.11, making this tool break on systems with earlier Python versions. This fix should behave identically and support back to Python 3.2, long before Galaxy's minimum Python version of 3.9
Author
|
Superseded by #7883 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the data manager so it runs on Python 3.10 and below.
Commit 797b5fc changed data_managers/data_manager_build_kraken2_database/ data_manager/kraken2_build_database.xml#59 from the deprecated datetime.utcnow() to datetime.now(datetime.UTC). However, datetime.UTC was introduced in Python 3.11, making this tool break on systems with earlier Python versions.
This fix should behave identically and support back to Python 3.2, long before Galaxy's minimum Python version of 3.9
FOR CONTRIBUTOR:
This is a compatibility fix for an existing tool.