Open
Conversation
Contributor
Author
|
Linting error mainly consist of missing data types:
|
Contributor
Can you add the missing datatypes here and target the PR to release_26.0 branch? |
SaimMomin12
reviewed
Mar 24, 2026
4 tasks
SaimMomin12
approved these changes
Mar 26, 2026
Contributor
SaimMomin12
left a comment
There was a problem hiding this comment.
LGTM! Lets ask for second pair of eyes on this.
Contributor
Author
|
Hi, are there any updates to this PR? |
Contributor
|
@bgruening can we merge this? |
bgruening
reviewed
Apr 17, 2026
Member
|
Yes, I think it can be merged. Thanks @Maed0x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR:
There are two labels that allow to ignore specific (false positive) tool linter errors:
skip-version-check: Use it if only a subset of the tools has been updated in a suite.skip-url-check: Use it if github CI sees 403 errors, but the URLs work.This PR adds taffy as a new tool (https://github.com/ComparativeGenomicsToolkit/taffy)