Skip to content

[26.0] Add new datatypes: .taf and .taf.gz#22242

Merged
bernt-matthias merged 7 commits intogalaxyproject:release_26.0from
Maed0x:taffy_datatypes
Mar 31, 2026
Merged

[26.0] Add new datatypes: .taf and .taf.gz#22242
bernt-matthias merged 7 commits intogalaxyproject:release_26.0from
Maed0x:taffy_datatypes

Conversation

@Maed0x
Copy link
Copy Markdown
Contributor

@Maed0x Maed0x commented Mar 24, 2026

This PR adds the datatypes .taf and .taf.gz to datatypes_conf.xml.sample. They are needed for the new tool addition taffy in #7826

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 26.1 milestone Mar 24, 2026
@github-actions github-actions bot changed the title Add new datatypes: .taf and .taf.gz [26.0] Add new datatypes: .taf and .taf.gz Mar 24, 2026
@SaimMomin12 SaimMomin12 requested a review from bgruening March 25, 2026 08:37
Comment thread lib/galaxy/config/sample/datatypes_conf.xml.sample Outdated
Comment thread lib/galaxy/config/sample/datatypes_conf.xml.sample Outdated
Maed0x and others added 2 commits March 25, 2026 14:50
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
@Maed0x Maed0x requested a review from bgruening March 25, 2026 14:15
Copy link
Copy Markdown
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth to add a sniffer?

@Maed0x
Copy link
Copy Markdown
Contributor Author

Maed0x commented Mar 27, 2026

Implementing a sniffer could be straightforward and quick because a .taf file can be detected by the #taf in the first line. So checking with file_prefix.startswith should already be enough. Should I make a commit for it?

@bernt-matthias
Copy link
Copy Markdown
Contributor

Implementing a sniffer could be straightforward and quick because a .taf file can be detected by the #taf in the first line. So checking with file_prefix.startswith should already be enough. Should I make a commit for it?

Maybe #tab plus at least one key value pair. #taf alone might be to unspecific.

@Maed0x
Copy link
Copy Markdown
Contributor Author

Maed0x commented Mar 27, 2026

@bernt-matthias I have added the taf sniffer. I have used the existing paf sniffer as reference.

Comment thread lib/galaxy/datatypes/text.py Outdated
Comment thread lib/galaxy/datatypes/text.py Outdated
@Maed0x Maed0x requested a review from bernt-matthias March 27, 2026 14:42
@bernt-matthias
Copy link
Copy Markdown
Contributor

test failures look unrelated. thanks @Maed0x

@bernt-matthias bernt-matthias merged commit f2949b3 into galaxyproject:release_26.0 Mar 31, 2026
48 of 55 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Galaxy Dev - weeklies Mar 31, 2026
@github-actions
Copy link
Copy Markdown

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo modified the milestones: 26.1, 26.0 Mar 31, 2026
@Maed0x
Copy link
Copy Markdown
Contributor Author

Maed0x commented Mar 31, 2026

Thank you very much @bernt-matthias !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants