Skip to content

Support all text styles for text input #24187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chronicl wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Support all text styles for text input #24187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/bevy_ui/src/widget/text_input_layout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,12 @@ pub fn update_editable_text_styles(
let family = font_family.into_owned();
let style_set = editable_text.editor.edit_styles();
style_set.insert(StyleProperty::FontFamily(family));
style_set.insert(StyleProperty::FontWeight(text_font.weight.into()));
style_set.insert(StyleProperty::FontWidth(text_font.width.into()));
style_set.insert(StyleProperty::FontStyle(text_font.style.into()));
style_set.insert(StyleProperty::FontFeatures(
Copy link
Copy Markdown
Contributor

@ickshonpe ickshonpe May 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask why you left out FontVariations, but I didn't realise the variations PR isn't merged yet. It looks like it got forgotten with all the problems we had with github a few days ago.

(&text_font.font_features).into(),
));
style_set.insert(StyleProperty::Brush(TextBrush::new(
0,
text_font.font_smoothing,
Expand Down
Loading