Support all text styles for text input#24187
Support all text styles for text input#24187chronicl wants to merge 1 commit intobevyengine:mainfrom
Conversation
mnmaita
added
C-Feature
ickshonpe
left a comment
ickshonpe
left a comment
There was a problem hiding this comment.
Ah yeah I think I just left out font features specifically because for some reason I thought, at some moment, it's just small caps and superscripts, no one needs that. But it isn't, and, of course, we should support the full text API.
I'd like us to add a few options to one of the examples (or a new example) with some controls to enable or disable some of these features. That should be left for a follow up though, there's no reason to hold up on merging this.
| style_set.insert(StyleProperty::FontWeight(text_font.weight.into())); | ||
| style_set.insert(StyleProperty::FontWidth(text_font.width.into())); | ||
| style_set.insert(StyleProperty::FontStyle(text_font.style.into())); | ||
| style_set.insert(StyleProperty::FontFeatures( |
There was a problem hiding this comment.
I was going to ask why you left out FontVariations, but I didn't realise the variations PR isn't merged yet. It looks like it got forgotten with all the problems we had with github a few days ago.
ickshonpe
added
D-Trivial
alice-i-cecile
added
S-Blocked
|
Blocked by #24088 |
alice-i-cecile
added
C-Bug
Zeophlite
added
S-Waiting-on-Author
5 participants
Objective
Current text inputs do not apply all styles set in
TextFontto their text.Solution
Set the missing text styles in
update_editable_text_styles.Testing
Tested in my own non-public project. If desired I can write or extend an existing example to showcase.