[WIP] Group field type and formatter by damiankloip · Pull Request #40 · amitaibu/og

damiankloip · 2015-11-24T16:29:52Z

No description provided.

pfrenssen · 2015-11-27T19:18:55Z

This method name is a bit confusing. Since this returns an array and Fields is plural this seems to indicate that it returns multiple (?) group audience fields. Maybe better would be getGroupAudienceFieldName().

Initially I thought it would be more useful to return the full field definition, but I suppose the machine name and label are the only interesting properties on it anyway.

This does return multiple? You can have more than one audience field attached to a bundle.

@pfrenssen you can indeed have multiple group audience fields. This usually makes more sense when thinking of the user entity. For example simple_ref would reference a group using the default OG membership type; and premium_ref would reference using some Premium OG membership type.

Each membership created also registers through which field it was saved - so on edit we know how to build the options list.

damiankloip · 2015-11-30T11:39:46Z

Don't think I really like this approach. Was just because it is in theory most flexible for the future. Not sure we would ever need to change this though? If not, I'll just hardcode the value to TRUE again in the OgGroupBoolean class.

damiankloip · 2015-11-30T13:48:04Z

@amitaibu So all the functions that need to be converted in here now, should I put those in separate PRs? Like og_is_member and friends?

amitaibu · 2015-11-30T13:49:53Z

Like og_is_member and friends?

Would be nice. Those smaller PRs are nicer to grok, and are removing blocks from other PRs.

damiankloip · 2015-11-30T13:50:35Z

👍

damiankloip · 2015-11-30T15:59:52Z

#53 is providing the isMember method.

damiankloip · 2015-12-02T14:05:29Z

Another dep resolved: #56

damiankloip · 2015-12-02T14:30:31Z

Will tackle og_get_best_group_audience_field next.

RoySegall · 2015-12-02T14:33:20Z

Isn't that an extra line?

damiankloip · 2015-12-02T19:37:26Z

For adding the subscribe/unsubscribe links: #59 Actually quite a bit of work involved there, as we need the routes, access checking, controller callbacks, and confirmation forms.

damiankloip · 2015-12-07T17:29:55Z

@pfrenssen could really do with that shiny new og_get_best_group_audience_field method now :)

…ttingsSummary method

…ptions for label

…lements method

…ield() method

amitaibu · 2016-07-25T17:20:19Z

@damiankloip will you have time to re-pick this issue, or do you prefer me to take this one?

amitaibu · 2016-08-04T17:54:49Z

I'll pick this one next, as it compliments #286

amitaibu · 2016-08-04T18:07:48Z

Closed in favor of #286

damiankloip force-pushed the group-formatter branch from c2271d3 to f4ba315 Compare November 24, 2015 16:31

damiankloip mentioned this pull request Nov 24, 2015

[WIP] Start converting hook_node_access to hook_entity_access for 8.x #38

Closed

damiankloip force-pushed the group-formatter branch from b0fdda2 to 0f42968 Compare November 26, 2015 16:22

pfrenssen reviewed Nov 27, 2015
View reviewed changes

damiankloip force-pushed the group-formatter branch 3 times, most recently from 41e1564 to fae8557 Compare November 30, 2015 11:02

damiankloip reviewed Nov 30, 2015
View reviewed changes

damiankloip mentioned this pull request Nov 30, 2015

Convert og_is_member to Og:isMember and add test coverage #53

Merged

damiankloip force-pushed the group-formatter branch from 1ea530d to 5aa7e1c Compare December 2, 2015 09:06

damiankloip mentioned this pull request Dec 2, 2015

Og check field cardinality #56

Merged

damiankloip force-pushed the group-formatter branch from d5644ee to 401e8e2 Compare December 2, 2015 14:24

RoySegall reviewed Dec 2, 2015
View reviewed changes

damiankloip mentioned this pull request Dec 2, 2015

[WIP] Subscribe/unsubscribe routes #59

Closed

damiankloip force-pushed the group-formatter branch from cb8228c to 61d25f5 Compare December 4, 2015 13:21

This was referenced Dec 6, 2015

Move og_ui in to modules subdirectory #68

Closed

Move OG UI to modules sub directory #69

Closed

damiankloip force-pushed the group-formatter branch from 61d25f5 to 958b97d Compare December 7, 2015 10:12

damiankloip reviewed Dec 7, 2015
View reviewed changes

damiankloip added 15 commits December 30, 2015 17:30

Add group field type, add subscribe formatter

e4a3d2a

Add default display to og_ui entity_bundle_info_alter instead, add se…

fd8ad87

…ttingsSummary method

Convert _og_get_group_audience_fields to Og:: method

6dcdbea

Add computed boolean value for group field value

480a9b2

Add helper to get option labels from Og::getAllGroupAudienceFields

1e3f65b

Add default setting value for field_name, always use audience field o…

ddd6cc4

…ptions for label

Feedback form Amitai and code tidy of GroupSubscriberFormatter::viewE…

0d680c3

…lements method

Simplify settingsSummary method

c880869

Remove usage of group_value setting

2c03acd

Use Og::isMember

9caeb7e

Add usage of OgGroupAudienceHelper::checkFieldCardinality

3a0d662

Use field_name setting

1ad173e

Convert links to use url parameters

13f5efc

Use OgAccess::userAccess in group formatter

b0489c7

Rename subscribe/unsubscribe routes

69a330f

damiankloip force-pushed the group-formatter branch from 113c950 to 69a330f Compare December 30, 2015 17:30

Update subscribe formatter to use OgGroupAudienceHelper::getMatchingF…

76951bc

…ield() method

amitaibu mentioned this pull request Aug 4, 2016

WIP: Add a group formatter for easier subscribe/ unsubscribe #286

Closed

amitaibu closed this Aug 4, 2016

amitaibu mentioned this pull request Aug 17, 2016

Add a group formatter for easier subscribe/ unsubscribe Gizra/og#141

Merged

Conversation

damiankloip commented Nov 24, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

damiankloip commented Nov 30, 2015

Uh oh!

amitaibu commented Nov 30, 2015

Uh oh!

damiankloip commented Nov 30, 2015

Uh oh!

damiankloip commented Nov 30, 2015

Uh oh!

damiankloip commented Dec 2, 2015

Uh oh!

damiankloip commented Dec 2, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

damiankloip commented Dec 2, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amitaibu commented Jul 25, 2016

Uh oh!

amitaibu commented Aug 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amitaibu commented Aug 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

amitaibu commented Aug 4, 2016 •

edited

Loading