Skip to content

[WIP] Subscribe/unsubscribe routes#59

Closed
damiankloip wants to merge 11 commits into
amitaibu:8.x-1.xfrom
damiankloip:og-ui-subscribe-routes
Closed

[WIP] Subscribe/unsubscribe routes#59
damiankloip wants to merge 11 commits into
amitaibu:8.x-1.xfrom
damiankloip:og-ui-subscribe-routes

Conversation

@damiankloip

Copy link
Copy Markdown
Collaborator

This is needed for #40. We need the subscribe and unsubscribe links.

@damiankloip damiankloip force-pushed the og-ui-subscribe-routes branch 2 times, most recently from 756642b to 590c6a9 Compare December 2, 2015 19:39
@damiankloip damiankloip changed the title [WIP] Add route definitions and Group access check service [WIP] Subscribe/unsubscribe routes Dec 2, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a variable placeholder iirc (:login)

@damiankloip damiankloip force-pushed the og-ui-subscribe-routes branch 2 times, most recently from 9653937 to 08de8fd Compare December 7, 2015 11:48
Comment thread og_ui/og_ui.routing.yml Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this use '_og_ui_user_access_group' ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In D7 only unsubscribe uses that.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't make the rules :p

@damiankloip damiankloip force-pushed the og-ui-subscribe-routes branch 2 times, most recently from e73425c to 7aadcf0 Compare December 9, 2015 16:02

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants