Og check field cardinality#56
Merged
amitaibu merged 6 commits intoDec 2, 2015
Merged
Conversation
Collaborator
Author
|
ping @amitaibu |
Owner
There was a problem hiding this comment.
maybe this should be called OgGroupAudience or OgGroupAudienceHelper? - I think it would make its content clearer
Collaborator
Author
There was a problem hiding this comment.
Sure, we can be more granular. I would go for OgGroupAudienceHelper.
Collaborator
Author
|
@amitaibu updated all the things. |
Owner
There was a problem hiding this comment.
OG audience field helper methods.
Owner
|
Thanks! |
Collaborator
Author
|
Cheers! Can now be used in #40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just ports the
og_check_field_cardinalityfunction, so should be pretty self sufficient.I created a new
OgHelperclass, as I think we should start using this for things that are more helpers than API. TheOgclass will get way overloaded (more than it is already :)).