[AMD-SMI] Allow amdsmi init to succeed when no NIC hardware is present - #3403
Merged
Conversation
Contributor
|
LGTM, will approve once AINIC is reimplemented. |
sputhala-amd
changed the title
dmitrii-galantsev
previously requested changes
Feb 21, 2026
Contributor
There was a problem hiding this comment.
blocking until NIC is re-implemented. it has been temporarily reverted.
#3418
1 task
marifamd
force-pushed
the
users/ajanicijamd/amd-smi-fix-for-ainic
branch
from
February 26, 2026 22:28
32a7f00 to
c36df37
Compare
marifamd
approved these changes
Feb 26, 2026
marifamd
changed the title
marifamd
changed the title
oosman330
approved these changes
Feb 27, 2026
marifamd
force-pushed
the
users/ajanicijamd/amd-smi-fix-for-ainic
branch
from
March 1, 2026 18:43
c36df37 to
bbd48e8
Compare
gabrpham
pushed a commit
that referenced
this pull request
Mar 12, 2026
#3403) * Quick fix for the code that populates all AI NIC devices * When no NIC found resturn success --------- Co-authored-by: Sajina Kandy <sputhala@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Allows amdsmi init to succeed when NIC-related hardware is absent.
Technical Details
Treat "no NIC driver" or "no NIC devices" as success in
populate_brcm_nic_devices()populate_brcm_switch_devices()andpopulate_amd_ainic_devices()JIRA ID
Test Plan
Test Result
Submission Checklist